Skip to content

fix: Added UIServer type to wrap UI server configuration in FeatureSt… #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdityaPatil22 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Added UIServer type to wrap UI server configuration in FeatureSt… #6727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e219198
fix: Nest UI server config under UIServer type
AdityaPatil22 Aug 11, 2026
67dfcd1
fix: Nest UI server config under UIServer type
AdityaPatil22 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@
"filename": "infra/feast-operator/api/v1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 958
"line_number": 963
}
],
"infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
Expand Down Expand Up @@ -989,7 +989,7 @@
"filename": "infra/feast-operator/api/v1alpha1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 663
"line_number": 668
}
],
"infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go": [
Expand Down Expand Up @@ -1564,5 +1564,5 @@
}
]
},
"generated_at": "2026-07-31T05:29:18Z"
"generated_at": "2026-08-11T11:34:51Z"
}
15 changes: 10 additions & 5 deletions infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,10 @@ type JobSpec struct {

// FeatureStoreServices defines the desired feast services. An ephemeral onlineStore feature server is deployed by default.
type FeatureStoreServices struct {
OfflineStore *OfflineStore `json:"offlineStore,omitempty"`
OnlineStore *OnlineStore `json:"onlineStore,omitempty"`
Registry *Registry `json:"registry,omitempty"`
// Creates a UI server container
UI *ServerConfigs `json:"ui,omitempty"`
OfflineStore *OfflineStore `json:"offlineStore,omitempty"`
OnlineStore *OnlineStore `json:"onlineStore,omitempty"`
Registry *Registry `json:"registry,omitempty"`
UI *UIServer `json:"ui,omitempty"`
DeploymentStrategy *appsv1.DeploymentStrategy `json:"deploymentStrategy,omitempty"`
SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"`
// PodAnnotations are annotations to be applied to the Deployment's PodTemplate metadata.
Expand Down Expand Up @@ -498,6 +497,12 @@ type PDBConfig struct {
MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"`
}

// UIServer configures the UI server service
type UIServer struct {
// Creates a UI server container
Server *ServerConfigs `json:"server,omitempty"`
}

// OfflineStore configures the offline store service
type OfflineStore struct {
// Creates a remote offline server container
Expand Down
22 changes: 21 additions & 1 deletion infra/feast-operator/api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 10 additions & 5 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,10 @@ type JobSpec struct {

// FeatureStoreServices defines the desired feast services. An ephemeral onlineStore feature server is deployed by default.
type FeatureStoreServices struct {
OfflineStore *OfflineStore `json:"offlineStore,omitempty"`
OnlineStore *OnlineStore `json:"onlineStore,omitempty"`
Registry *Registry `json:"registry,omitempty"`
// Creates a UI server container
UI *ServerConfigs `json:"ui,omitempty"`
OfflineStore *OfflineStore `json:"offlineStore,omitempty"`
OnlineStore *OnlineStore `json:"onlineStore,omitempty"`
Registry *Registry `json:"registry,omitempty"`
UI *UIServer `json:"ui,omitempty"`
DeploymentStrategy *appsv1.DeploymentStrategy `json:"deploymentStrategy,omitempty"`
SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"`
// Disable the 'feast repo initialization' initContainer
Expand All @@ -307,6 +306,12 @@ type FeatureStoreServices struct {
Volumes []corev1.Volume `json:"volumes,omitempty"`
}

// UIServer configures the UI server service
type UIServer struct {
// Creates a UI server container
Server *ServerConfigs `json:"server,omitempty"`
}

// OfflineStore configures the offline store service
type OfflineStore struct {
// Creates a remote offline server container
Expand Down
22 changes: 21 additions & 1 deletion infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading