Skip to content

test: Add cron job check for e2e test runTestDeploySimpleCRFunc - #6705

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
Srihari1192:addCronJobTestCheck
Aug 14, 2026
Merged

test: Add cron job check for e2e test runTestDeploySimpleCRFunc#6705
ntkathole merged 1 commit into
feast-dev:masterfrom
Srihari1192:addCronJobTestCheck

Conversation

@Srihari1192

@Srihari1192 Srihari1192 commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Add checkIfCronJobExists helper in feast-operator e2e utils
  • Validate CronJob feast-<featureStoreName> exists in validateTheFeatureStoreCustomResource before FeatureStore Ready checks
  • Covers runTestDeploySimpleCRFunc and the remote-registry deploy path that share this validation

Which issue(s) this PR fixes:

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@Srihari1192
Srihari1192 force-pushed the addCronJobTestCheck branch from 9b2714d to d9b9caa Compare August 5, 2026 09:12
@codecov-commenter

codecov-commenter commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.81%. Comparing base (97b0f25) to head (9301202).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6705   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         415      415           
  Lines       50399    50399           
  Branches     7214     7214           
=======================================
  Hits        23592    23592           
  Misses      25157    25157           
  Partials     1650     1650
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.13% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b0f25...9301202. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Srihari1192 Srihari1192 changed the title test:Add cron job check for e2e test runTestDeploySimpleCRFunc test: Add cron job check for e2e test runTestDeploySimpleCRFunc Aug 5, 2026
@Srihari1192
Srihari1192 marked this pull request as ready for review August 5, 2026 10:17
@Srihari1192
Srihari1192 requested a review from a team as a code owner August 5, 2026 10:17
ntkathole
ntkathole reviewed Aug 5, 2026
View reviewed changes
Comment thread infra/feast-operator/test/utils/test_util.go
@Srihari1192
Srihari1192 requested a review from ntkathole August 6, 2026 05:27
@Srihari1192
Srihari1192 force-pushed the addCronJobTestCheck branch from d9b9caa to b54c7ba Compare August 6, 2026 07:33
This was referenced Aug 6, 2026
Merged
Open
Open
@Srihari1192 @ntkathole
test:Add cron job check for e2e test runTestDeploySimpleCRFunc
9301202 
Signed-off-by: Srihari <svenkata@redhat.com>
@ntkathole
ntkathole force-pushed the addCronJobTestCheck branch from f6a8635 to 9301202 Compare August 14, 2026 06:18
@ntkathole
ntkathole merged commit e56578d into feast-dev:master Aug 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Srihari1192 @codecov-commenter @ntkathole