-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: Add gRPC timeout and keepalive to RemoteRegistry #6698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Arthur-plg
wants to merge
3
commits into
feast-dev:master
Choose a base branch
from
Arthur-plg:fix/remote-registry-grpc-timeout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| import grpc | ||
| from google.protobuf.empty_pb2 import Empty | ||
| from google.protobuf.timestamp_pb2 import Timestamp | ||
| from pydantic import StrictStr | ||
| from pydantic import StrictStr, field_validator | ||
|
|
||
| from feast.base_feature_view import BaseFeatureView | ||
| from feast.data_source import DataSource | ||
|
|
@@ -93,6 +93,22 @@ class RemoteRegistryConfig(RegistryConfig): | |
| Required when the connection address differs from the service hostname, | ||
| e.g. when connecting through a tunnel or proxy for local development. """ | ||
|
|
||
| timeout: Optional[int] = None | ||
| """ int: Timeout in seconds for registry gRPC calls. Must be strictly positive. """ | ||
|
|
||
| keepalive_time_ms: Optional[int] = None | ||
| """ int: Period in milliseconds after which a keepalive ping is sent on the transport. Must be strictly positive. """ | ||
|
|
||
| keepalive_timeout_ms: Optional[int] = None | ||
| """ int: Timeout in milliseconds for keepalive ping acknowledgement. Must be strictly positive. """ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should there be keepalive_permit_without_calls also ? |
||
|
|
||
| @field_validator("timeout", "keepalive_time_ms", "keepalive_timeout_ms") | ||
| @classmethod | ||
| def validate_positive_values(cls, v: Optional[int]) -> Optional[int]: | ||
| if v is not None and v <= 0: | ||
| raise ValueError("value must be strictly positive (> 0)") | ||
| return v | ||
|
|
||
|
|
||
| class RemoteRegistry(BaseRegistry): | ||
| def __init__( | ||
|
|
@@ -107,12 +123,27 @@ def __init__( | |
| self.channel = self._create_grpc_channel(registry_config) | ||
| weakref.finalize(self, self.channel.close) | ||
|
|
||
| auth_header_interceptor = GrpcClientAuthHeaderInterceptor(auth_config) | ||
| auth_header_interceptor = GrpcClientAuthHeaderInterceptor( | ||
| auth_config, timeout=registry_config.timeout | ||
| ) | ||
| self.channel = grpc.intercept_channel(self.channel, auth_header_interceptor) | ||
| self.stub = RegistryServer_pb2_grpc.RegistryServerStub(self.channel) | ||
|
|
||
| def _create_grpc_channel(self, registry_config): | ||
| assert isinstance(registry_config, RemoteRegistryConfig) | ||
|
|
||
| options = [] | ||
| if registry_config.authority: | ||
| options.append(("grpc.default_authority", registry_config.authority)) | ||
| if registry_config.keepalive_time_ms is not None: | ||
| options.append( | ||
| ("grpc.keepalive_time_ms", registry_config.keepalive_time_ms) | ||
| ) | ||
| if registry_config.keepalive_timeout_ms is not None: | ||
| options.append( | ||
| ("grpc.keepalive_timeout_ms", registry_config.keepalive_timeout_ms) | ||
| ) | ||
|
|
||
| if registry_config.cert or registry_config.is_tls: | ||
| cafile = ( | ||
| registry_config.cert | ||
|
|
@@ -146,16 +177,12 @@ def _create_grpc_channel(self, registry_config): | |
| certificate_chain=certificate_chain, | ||
| ) | ||
|
|
||
| options = [] | ||
| if registry_config.authority: | ||
| options.append(("grpc.default_authority", registry_config.authority)) | ||
|
|
||
| return grpc.secure_channel( | ||
| registry_config.path, tls_credentials, options=options | ||
| ) | ||
| else: | ||
| # Create an insecure gRPC channel | ||
| return grpc.insecure_channel(registry_config.path) | ||
| return grpc.insecure_channel(registry_config.path, options=options) | ||
|
|
||
| def close(self): | ||
| if self.channel: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be Optional[float] (or Optional[Union[int, float]]) ?