Skip to content

fix: Add remote registry client extra - #6697

Merged
ntkathole merged 2 commits into
feast-dev:masterfrom
yaodong-shen:fix/remote-registry-client-extra
Aug 14, 2026
Merged

fix: Add remote registry client extra#6697
ntkathole merged 2 commits into
feast-dev:masterfrom
yaodong-shen:fix/remote-registry-client-extra

Conversation

@yaodong-shen

@yaodong-shen yaodong-shen commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Fixes #6666. RemoteRegistry imports grpc unconditionally, but grpcio was only available through the unrelated server-oriented grpcio extra. Users installing a normal provider extra could therefore configure registry_type: remote and receive ModuleNotFoundError at runtime.

This adds a focused remote optional dependency containing only grpcio and documents pip install "feast[remote]" next to the remote registry configuration. The existing grpcio extra remains unchanged for registry/feature-server deployments that need reflection and health-checking packages.

Validation

  • Verified the final branch diff contains only pyproject.toml and docs/reference/registries/remote.md.
  • Verified the TOML extra and documentation text from the master blobs.
  • Full Feast dependency installation and unit test suite were not runnable locally because the network clone did not complete; CI should exercise package metadata and docs checks.

Release notes

NONE

@yaodong-shen
yaodong-shen requested a review from a team as a code owner August 1, 2026 17:05
@yaodong-shen

yaodong-shen commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

The implementation is ready and the branch is mergeable. Per the repository contribution guide, could a maintainer add the required kind/bug and ok-to-test labels so the Prow checks can run? The DCO check still correctly awaits the contributor's explicit sign-off authorization.

@yaodong-shen
yaodong-shen force-pushed the fix/remote-registry-client-extra branch from ca3823a to 9e9ee68 Compare August 2, 2026 01:03
franciscojavierarceo
franciscojavierarceo approved these changes Aug 3, 2026
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focused extra cleanly separates the client-only grpcio dependency and documents the installation path without changing the existing server extra. I found no blocking issue in the remote diff.

@codecov-commenter

codecov-commenter commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.81%. Comparing base (01da132) to head (43c0ea3).
⚠️ Report is 5 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6697   +/-   ##
=======================================
  Coverage   46.80%   46.81%           
=======================================
  Files         415      415           
  Lines       50395    50396    +1     
  Branches     7214     7214           
=======================================
+ Hits        23587    23591    +4     
+ Misses      25155    25154    -1     
+ Partials     1653     1651    -2
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.13% <ø> (+<0.01%) ⬆️
see 2 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef4e78...43c0ea3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yaodong-shen
yaodong-shen force-pushed the fix/remote-registry-client-extra branch from 6bb1eb7 to 47f74b3 Compare August 11, 2026 08:32
@ntkathole
ntkathole force-pushed the fix/remote-registry-client-extra branch from 47f74b3 to 43c0ea3 Compare August 14, 2026 04:40
@yaodong-shen @ntkathole
fix: add remote registry client extra
0ccc290 
Signed-off-by: buduoqiu <shenyaodong@hhu.edu.cn>
@yaodong-shen @ntkathole
chore: update Pixi lock for remote extra
e3b331b 
Signed-off-by: buduoqiu <shenyaodong@hhu.edu.cn>
@ntkathole
ntkathole force-pushed the fix/remote-registry-client-extra branch from 43c0ea3 to e3b331b Compare August 14, 2026 07:56
@ntkathole
ntkathole merged commit b8dfcb0 into feast-dev:master Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes
@ntkathole ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remote registry client fails with ModuleNotFoundError: No module named 'grpc' unless the unrelated [grpcio] extra is installed

4 participants

@yaodong-shen @codecov-commenter @franciscojavierarceo @ntkathole