fix: Use join keys instead of entity names in ODFV materialization - #6645
Merged
ntkathole merged 2 commits intoJul 30, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6645 +/- ##
==========================================
+ Coverage 45.98% 46.27% +0.28%
==========================================
Files 414 414
Lines 50037 50045 +8
Branches 7147 7147
==========================================
+ Hits 23012 23157 +145
+ Misses 25413 25251 -162
- Partials 1612 1637 +25
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
fix/5965-odfv-materialize-join-keys
branch
from
July 30, 2026 05:16
35c0c36 to
3964cca
Compare
ntkathole
approved these changes
Jul 30, 2026
_materialize_odfv used FeatureView.entities (entity names) instead of FeatureView.join_keys (actual join key column names) when building the entity DataFrame and querying the offline store during ODFV materialization. When an Entity's name differs from its join_keys (a supported, documented pattern), this caused materialization to query for a nonexistent column, breaking materialize()/materialize_incremental() for any OnDemandFeatureView with write_to_online_store=True sourced from such a feature view. Fixes feast-dev#5965 Signed-off-by: Anshi Shrivastava <anshi4shrivastava@gmail.com>
Signed-off-by: Anshi Shrivastava <anshi4shrivastava@gmail.com>
ntkathole
force-pushed
the
fix/5965-odfv-materialize-join-keys
branch
from
July 30, 2026 06:05
3964cca to
71463c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
_materialize_odfvusedFeatureView.entities(entity names) instead ofFeatureView.join_keys(actual join key column names) when building theentity DataFrame and querying the offline store during ODFV materialization.
When an
Entity'snamediffers from itsjoin_keys(a supported, documentedpattern), this caused materialization to query for a nonexistent column,
breaking
materialize()/materialize_incremental()for anyOnDemandFeatureView with
write_to_online_store=Truesourced from such afeature view.
This fixes both call sites in
_materialize_odfvto usesource_fv.join_keysinstead of
source_fv.entities.Which issue(s) this PR fixes:
Fixes #5965
Checks
git commit -s)Testing Strategy
Misc
Added a regression test (
test_materialize_incremental_odfv_entity_name_differs_from_join_keyin
sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py) withan
Entitywhosenamediffers from itsjoin_keys. Confirmed it fails onmaster and passes with this fix.