Skip to content

feat: Add MLflow integration support to Feast operator - #6611

Open
Vperiodt wants to merge 7 commits into
feast-dev:masterfrom
Vperiodt:feast-mlflow-rhoai
Open

feat: Add MLflow integration support to Feast operator#6611
Vperiodt wants to merge 7 commits into
feast-dev:masterfrom
Vperiodt:feast-mlflow-rhoai

Conversation

@Vperiodt

@Vperiodt Vperiodt commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Adds optional spec.mlflow.uiUrl and wires it into feature_store.yaml as ui_url
  • Auto-discovers tracking URI (status.address.url) and UI URL (status.url) from the cluster MLflow CR
  • Feast UI lineage links use MlflowConfig.get_ui_url() (falls back to tracking URI for local/dev)

Which issue(s) this PR fixes:

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.80%. Comparing base (b8dfcb0) to head (098fcbd).

Files with missing lines Patch % Lines
sdk/python/feast/mlflow_integration/config.py 0.00% 8 Missing ⚠️
sdk/python/feast/ui_server.py 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
- Coverage   46.81%   46.80%   -0.01%     
==========================================
  Files         415      415              
  Lines       50399    50407       +8     
  Branches     7214     7215       +1     
==========================================
  Hits        23592    23592              
- Misses      25157    25165       +8     
  Partials     1650     1650              
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.12% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
sdk/python/feast/ui_server.py 24.64% <0.00%> (ø)
sdk/python/feast/mlflow_integration/config.py 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dfcb0...098fcbd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vperiodt
Vperiodt marked this pull request as ready for review July 21, 2026 11:40
@Vperiodt
Vperiodt requested a review from a team as a code owner July 21, 2026 11:40
needsDiscovery := cr.Spec.Mlflow.TrackingUri == nil || cr.Spec.Mlflow.UiUrl == nil
if needsDiscovery && feast.Handler.Client != nil {
if discovered, ok := DiscoverMlflow(feast.Handler.Context, feast.Handler.Client); ok {
if cr.Status.Applied.Mlflow.TrackingUri == nil {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if cr.Status.Applied.Mlflow.TrackingUri == nil {
if cr.Status.Applied.Mlflow != nil && cr.Status.Applied.Mlflow.TrackingUri == nil {

return condStatus == "True"
}
}
return true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return false, Returning true here could cause the operator to use a partially-initialized MLflow instance.

return
}
mlflowEnv := []corev1.EnvVar{
{Name: "MLFLOW_TRACKING_AUTH", Value: "kubernetes-namespaced"},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be configurable and not hard-coded

rb.RoleRef = rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "ClusterRole",
Name: "mlflow-integration",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the MLflow operator provide this role ? I don't see logic to create

EntityDfMaxRows *int32 `yaml:"entity_df_max_rows,omitempty"`
LogOperations *bool `yaml:"log_operations,omitempty"`
OpsExperimentSuffix *string `yaml:"ops_experiment_suffix,omitempty"`
ExtraConfig map[string]interface{} `yaml:",inline,omitempty"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user puts tracking_uri or enabled in ExtraConfig, it would create conflicting/duplicate YAML keys. A kubebuilder validation rule or runtime check should prevent this.

func (r *FeatureStoreReconciler) mapMlflowToFeastRequests(ctx context.Context, _ client.Object) []reconcile.Request {
logger := log.FromContext(ctx)
var feastList feastdevv1.FeatureStoreList
if err := r.List(ctx, &feastList, client.InNamespace("")); err != nil {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider improving client.InNamespace("")); (rate-limiting / debounce strategy) lists FeatureStores across the entire cluster on every MLflow CR change. On large clusters this could produce significant API server load.

@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 880895c to 7774e4c Compare August 4, 2026 09:11
@ntkathole

Copy link
Copy Markdown
Member

@Vperiodt get_mlflow_feature_models is not fixed, still uses tracking_uri

https://github.com/Vperiodt/feast/blob/86691c91b273346f160027d0b9f3bc2e7fbd282e/sdk/python/feast/ui_server.py#L1122

mlflow_ui_base = (
    mlflow_cfg.get_ui_url() or mlflow.get_tracking_uri() or ""
)

@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 81745f4 to b441f95 Compare August 11, 2026 14:46
@ntkathole

Copy link
Copy Markdown
Member

@Vperiodt please fix linting and conflicts

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Update .secrets.baseline line numbers after MLflow CRD/controller
additions so detect-secrets pre-commit passes in CI.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Regenerate .secrets.baseline from master so detect-secrets line numbers
match the MLflow operator changes and CI pre-commit stays stable.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from b441f95 to 84b65ed Compare August 14, 2026 08:33
Use mlflow_cfg.get_ui_url() as the base URL for model links in
get_mlflow_feature_models, consistent with get_mlflow_experiments.
Falls back to mlflow.get_tracking_uri() when no explicit UI URL is set.

Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>
@Vperiodt
Vperiodt force-pushed the feast-mlflow-rhoai branch from 84b65ed to 098fcbd Compare August 14, 2026 10:57
@Vperiodt

Copy link
Copy Markdown
Contributor Author

@Vperiodt please fix linting and conflicts

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants