feat(operator): Add spec.services.initImage for init container image override - #6598
Merged
Merged
Conversation
Collaborator
|
@aniketpalu Please resolve checks failures and rebase the PR. |
aniketpalu
force-pushed
the
fix/init-container-image
branch
from
July 29, 2026 08:38
2bd80e2 to
80f8b53
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6598 +/- ##
=======================================
Coverage 46.43% 46.44%
=======================================
Files 414 414
Lines 50125 50134 +9
Branches 7172 7173 +1
=======================================
+ Hits 23275 23284 +9
+ Misses 25213 25212 -1
- Partials 1637 1638 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
franciscojavierarceo
requested changes
Jul 29, 2026
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
Member
There was a problem hiding this comment.
This adds initImage only to the v1 API. The served/deprecated v1alpha1 FeatureStoreServices type, deepcopy output, and CRD schema are unchanged, so the same resource cannot round-trip or use the new field through that served version. The operator currently keeps both API versions in sync for new fields. Please add the field and generated artifacts for v1alpha1 (plus conversion/round-trip coverage), or explicitly document and enforce that new fields are no longer supported there.
Member
|
v1alpha1 is deprecated |
Member
|
@aniketpalu please resolve conflicts |
aniketpalu
force-pushed
the
fix/init-container-image
branch
from
July 30, 2026 09:51
80f8b53 to
93a2ead
Compare
…override Init containers (feast-init, feast-apply) previously only used RELATED_IMAGE_FEATURE_SERVER or the compiled-in DefaultImage, ignoring per-FeatureStore custom images. This blocked users with custom Feast images (e.g. Spark-capable) unless an admin patched the operator. Add spec.services.initImage with resolution order: initImage → RELATED_IMAGE_FEATURE_SERVER → DefaultImage Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Shift detect-secrets baseline line numbers for featurestore_types.go and zz_generated.deepcopy.go after adding InitImage. Signed-off-by: Aniket Paluskar <apaluska@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ntkathole
force-pushed
the
fix/init-container-image
branch
from
July 30, 2026 13:04
93a2ead to
9a2483f
Compare
ShumzZzZz
added a commit
to ShumzZzZz/feast
that referenced
this pull request
Jul 30, 2026
Merge current master after feast-dev#6598 and resolve init container image selection as services.initImage, packaged.image, RELATED_IMAGE_FEATURE_SERVER, then DefaultImage. Preserve the upstream onlineStore.disabled defaults and regenerate operator artifacts. Signed-off-by: Shumin <shumin.zheng@outlook.com>
7 tasks
ShumzZzZz
added a commit
to ShumzZzZz/feast
that referenced
this pull request
Jul 31, 2026
Add spec.feastProjectDir.packaged for repositories distributed in feature server images, including staged and direct-use lifecycle modes, canonical path validation, generated CRD artifacts, documentation, and tests. Integrate the init image override introduced by feast-dev#6598 with this precedence: services.initImage, packaged.image, RELATED_IMAGE_FEATURE_SERVER, then DefaultImage. Signed-off-by: Shumin <shumin.zheng@outlook.com>
ShumzZzZz
added a commit
to ShumzZzZz/feast
that referenced
this pull request
Jul 31, 2026
Add spec.feastProjectDir.packaged for repositories distributed in feature server images, including staged and direct-use lifecycle modes, canonical path validation, generated CRD artifacts, documentation, and tests. Integrate the init image override introduced by feast-dev#6598 with this precedence: services.initImage, packaged.image, RELATED_IMAGE_FEATURE_SERVER, then DefaultImage. Signed-off-by: Shumin <shumin.zheng@outlook.com>
ntkathole
pushed a commit
that referenced
this pull request
Jul 31, 2026
Add spec.feastProjectDir.packaged for repositories distributed in feature server images, including staged and direct-use lifecycle modes, canonical path validation, generated CRD artifacts, documentation, and tests. Integrate the init image override introduced by #6598 with this precedence: services.initImage, packaged.image, RELATED_IMAGE_FEATURE_SERVER, then DefaultImage. Signed-off-by: Shumin <shumin.zheng@outlook.com>
jyejare
pushed a commit
to opendatahub-io/feast
that referenced
this pull request
Aug 5, 2026
…override (feast-dev#6598) * feat(operator): add spec.services.initImage for init container image override Init containers (feast-init, feast-apply) previously only used RELATED_IMAGE_FEATURE_SERVER or the compiled-in DefaultImage, ignoring per-FeatureStore custom images. This blocked users with custom Feast images (e.g. Spark-capable) unless an admin patched the operator. Add spec.services.initImage with resolution order: initImage → RELATED_IMAGE_FEATURE_SERVER → DefaultImage Signed-off-by: Aniket Paluskar <apaluska@redhat.com> * chore(operator): update secrets baseline after initImage API change Shift detect-secrets baseline line numbers for featurestore_types.go and zz_generated.deepcopy.go after adding InitImage. Signed-off-by: Aniket Paluskar <apaluska@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Aniket Paluskar <apaluska@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
jyejare
pushed a commit
to opendatahub-io/feast
that referenced
this pull request
Aug 5, 2026
Add spec.feastProjectDir.packaged for repositories distributed in feature server images, including staged and direct-use lifecycle modes, canonical path validation, generated CRD artifacts, documentation, and tests. Integrate the init image override introduced by feast-dev#6598 with this precedence: services.initImage, packaged.image, RELATED_IMAGE_FEATURE_SERVER, then DefaultImage. Signed-off-by: Shumin <shumin.zheng@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add spec.services.initImage for init container image override.
Init containers (feast-init, feast-apply) previously only used RELATED_IMAGE_FEATURE_SERVER or the compiled-in DefaultImage, ignoring per-FeatureStore custom images. This blocked users with custom Feast images (e.g. Spark-capable) unless an admin patched the operator. Add spec.services.initImage with resolution order:
initImage → RELATED_IMAGE_FEATURE_SERVER → DefaultImage
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc