Skip to content

Fix redis cluster e2e#659

Merged
feast-ci-bot merged 3 commits intofeast-dev:masterfrom
terryyylim:e2e-redis-cluster-fix
Apr 28, 2020
Merged

Fix redis cluster e2e#659
feast-ci-bot merged 3 commits intofeast-dev:masterfrom
terryyylim:e2e-redis-cluster-fix

Conversation

@terryyylim
Copy link
Copy Markdown
Member

@terryyylim terryyylim commented Apr 28, 2020

What this PR does / why we need it:
Fixes end to end test scripts to use config introduced by #502

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Apr 28, 2020

Hi @terryyylim. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrzzy
Copy link
Copy Markdown
Collaborator

mrzzy commented Apr 28, 2020

/ok-to-test

@terryyylim
Copy link
Copy Markdown
Member Author

terryyylim commented Apr 28, 2020

/test test-end-to-end-redis-cluster

woop
woop previously approved these changes Apr 28, 2020
View reviewed changes
@woop
Copy link
Copy Markdown
Member

woop commented Apr 28, 2020

Need to change .prow/scripts/download-maven-cache.sh to infra/scripts/download-maven-cache.sh

@terryyylim
Copy link
Copy Markdown
Member Author

terryyylim commented Apr 28, 2020

/retest

@terryyylim
Copy link
Copy Markdown
Member Author

terryyylim commented Apr 28, 2020

/test test-end-to-end-redis-cluster

@terryyylim
Copy link
Copy Markdown
Member Author

terryyylim commented Apr 28, 2020

/retest

1 similar comment
@khorshuheng
Copy link
Copy Markdown
Collaborator

khorshuheng commented Apr 28, 2020

/retest

@khorshuheng
Copy link
Copy Markdown
Collaborator

khorshuheng commented Apr 28, 2020

/test

@khorshuheng
Copy link
Copy Markdown
Collaborator

khorshuheng commented Apr 28, 2020

/lgtm

@khorshuheng
Copy link
Copy Markdown
Collaborator

khorshuheng commented Apr 28, 2020

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Apr 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terryyylim terryyylim changed the title [WIP] Fix redis cluster e2e Fix redis cluster e2e Apr 28, 2020
@feast-ci-bot feast-ci-bot merged commit 93a14a8 into feast-dev:master Apr 28, 2020
@woop woop mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop left review comments

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pradithya pradithya Awaiting requested review from pradithya

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@khorshuheng khorshuheng

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@terryyylim @feast-ci-bot @mrzzy @woop @khorshuheng