Add Field Status metadata to Online Serving#658

Merged

feast-ci-bot merged 65 commits into

feast-dev:masterfrom

mrzzy:online-feature-metadata

Jun 19, 2020

Commits on Jun 18, 2020

Update ServingService protobuf with additions to support online metadata retrieval.

Zhu Zhanyan
authored and
mrzzy
committed
Change error thrown by sendMultiGet() to Unknown as it describes the fault more accurately

Zhu Zhanyan
authored and
mrzzy
committed
Return boolean primitive instead of Boolean object type in FeatureRowDecoder

Zhu Zhanyan
authored and
mrzzy
committed
Config sendAndProcessMultiGet() to throw an exception on feature row decoding failure.

Zhu Zhanyan
authored and
mrzzy
committed
Refactor sendMultiGetAndProcess() to getFeaturesForFeatureSet().

Zhu Zhanyan
authored and
mrzzy
committed
Update ResponseJSONMapper to use new GetOnlineFeatures protobuf

Zhu Zhanyan
authored and
mrzzy
committed
Remove references to FieldValues in OnlineServingService & Tests

Zhu Zhanyan
authored and
mrzzy
committed
Update java sdk's FieldClient to use the new GetOnlineFeatures protobuf

Zhu Zhanyan
authored and
mrzzy
committed
Update OnlineRetriever to return null on missing retrieval (such as missing key for redis).

Zhu Zhanyan
authored and
mrzzy
committed
Refactor out unnecessary nesting of returned list in OnlineRetriever's getOnlineFeatures()

Zhu Zhanyan
authored and
mrzzy
committed
Add online feature metadata to OnlineServingService's getOnlineFeatures()

Zhu Zhanyan
authored and
mrzzy
committed
Update OnlineServingServiceTest to check that online metadata is set correctly.

Zhu Zhanyan
authored and
mrzzy
committed
Added online metadata support java sdk's FeastClient.

Zhu Zhanyan
authored and
mrzzy
committed
Changed go sdk's Row to store a map of fields instead of just Values

Zhu Zhanyan
authored and
mrzzy
committed
Update response.go to use updated Row and take into account FieldStatus

Zhu Zhanyan
authored and
mrzzy
committed
Added Field() to go sdk's types.go to construct fields from a Value.

Zhu Zhanyan
authored and
mrzzy
committed
Update go sdk's request.go to use updated Row and Add GetOnlineFeatures flags

Zhu Zhanyan
authored and
mrzzy
committed
Update go protobuf generated code for updated protobuf defintion

Zhu Zhanyan
authored and
mrzzy
committed
Update python sdk's client to document new fieldstatus metadata, added flags

Zhu Zhanyan
authored and
mrzzy
committed
Fixed issue where getOnlineFeatures() returned Record in a non deterministic order.

Zhu Zhanyan
authored and
mrzzy
committed
Update e2e ingestion tests to support new get_online_features api and check for metadata

Zhu Zhanyan
authored and
mrzzy
committed
Fixed NullPointerException when feature row is null.

Zhu Zhanyan
authored and
mrzzy
committed
Fixed issue in which unpackFields(entityRow) was not responding to includeMetadata flag

Zhu Zhanyan
authored and
mrzzy
committed
Check FieldStatus in end to end tests to wait for ingestion of values to complete.

Zhu Zhanyan
authored and
mrzzy
committed
Moved test checks out of polling loop in e2e online ingestion tests

Zhu Zhanyan
authored and
mrzzy
committed
Apply spotless java formatting

Zhu Zhanyan
authored and
mrzzy
committed
Fixed misplaced break in end to end tests

Zhu Zhanyan
authored and
mrzzy
committed
Fixed typos in e2e ingestion tests.

Zhu Zhanyan
authored and
mrzzy
committed
Apply changes on RedisOnlineRetriever to RedisClusterOnlineRetriever

Zhu Zhanyan
authored and
mrzzy
committed
Rename getFeaturesForFeatureSet() to getFeaturesFromRedis() for better sementics

Zhu Zhanyan
authored and
mrzzy
committed
Update Serving application.yml to include example on how to config RedisCluster

Zhu Zhanyan
authored and
mrzzy
committed
Correct missing include_meta flag in e2e tests get_online_features() calls

Zhu Zhanyan
authored and
mrzzy
committed
Correct minor comment typo in serving's application.yml

Zhu Zhanyan
authored and
mrzzy
committed
Correct another minor typo in e2e test: missing .status

Zhu Zhanyan
authored and
mrzzy
committed
Fix Feast core and serving compilation/test failures after rebase
mrzzy
committed
Fix go SDK tests after rebase
mrzzy
committed
Update ServingService protobuf to include metadata without breaking changes.
mrzzy
committed
Revert Feast Serving's ServingService & ResponseJSONMapper to FieldValues
mrzzy
committed
Revert serving's OnlineServingService to backwards compatible FieldValues API
mrzzy
committed
Revert Java SDK's FeastClient to backwards compatible FieldStatus API.
mrzzy
committed
Revert Go SDK's client.go to backwards compatible FieldStatus API.
mrzzy
committed
Fix Java SDK unit tests
mrzzy
committed
Added .Statuses() method to GO Sdk's OnlineFeaturesResponse to get metadata
mrzzy
committed
Fixed Java SDK not stripping project from field values and statuses
mrzzy
committed
Fixed Go SDK's client.go not stripping project from field values and statuses
mrzzy
committed
Fixed Go SDK's Unit tests
mrzzy
committed
Revert Python SDK to backward compatible FieldValues API & fix tests
mrzzy
committed
Move hardcoded constants from job.py to constants.py in Python SDK to consolidate constants
mrzzy
committed
Added wait backoff implementation in Python SDK: wait_retry_backoff()
mrzzy
committed
Update Python SDK's job.py to use shared backoff wait implemetation
mrzzy
committed
Clarify that maximum range in ServingService proto to max age
mrzzy
committed
Fixed online serving e2e tests
mrzzy
committed
Fix python lint.
mrzzy
committed
Collect entity refs in Python SDK as a single line.
mrzzy
committed
Use guard style if statements in Go Sdk's types.go
mrzzy
committed
Make strip field values part of Python SDK's get_online_features() more functional
mrzzy
committed
Fix go unit tests
mrzzy
committed
Remove include_metadata_in_response flag from ServingService proto as its redundant.
mrzzy
committed
Readd missing span log call to log retrieved feature rows.
mrzzy
committed
Use more modern Streams.zip() to iterate entity rows and feature rows in OnlineServingService
mrzzy
committed
Change utility methods in OnlineServingService to static.
mrzzy
committed
Use "outside max age" instead "stale" term in OnlineServingService as "stale" is a overloaded term.
mrzzy
committed
Refactor serving's OnlineRetriever to return a empty Optional<FeatureRow> instead of returning null.
mrzzy
committed
Fixed typo in basic redis e2e tests
mrzzy
committed
Fixed typo OnlineServingService's logFeatureRowsTrace()
mrzzy
committed