Skip to content

fix: implement RegistryServer.Proto gRPC method #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nquinn408 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

fix: implement RegistryServer.Proto gRPC method #6552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/python/feast/registry_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
str_to_auth_manager_type,
)
from feast.project import Project
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.protos.feast.registry import RegistryServer_pb2, RegistryServer_pb2_grpc
from feast.protos.feast.registry.RegistryServer_pb2 import Feature, ListFeaturesResponse
from feast.saved_dataset import SavedDataset, ValidationReference
Expand Down Expand Up @@ -180,6 +181,9 @@ def __init__(self, registry: BaseRegistry) -> None:
super().__init__()
self.proxied_registry = registry

def Proto(self, request: Empty, context) -> RegistryProto:
return self.proxied_registry.proto()

@ntkathole ntkathole Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nquinn408 it was intentionally removed, so that it won't return all information to the users not having access. Probably proper rbac needs to be added if we need it for any purpose.

@nquinn408 nquinn408 Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand @ntkathole but then it breaks RemoteRegistry.proto, so I don't know what the solution is. I guess a different implementation for RemoteRegistry.proto?

@nquinn408 nquinn408 Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feast/sdk/python/feast/infra/registry/remote.py

Line 691 in a834126

def proto(self) -> RegistryProto:

@ntkathole ntkathole Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can construct the response by calling each typed List* method (have RBAC checks) rather than forwarding the raw proto().

@nquinn408 nquinn408 Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an open issue to address? I will give it a shot.

@ntkathole ntkathole Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #6558


def ApplyEntity(self, request: RegistryServer_pb2.ApplyEntityRequest, context):
entity = cast(
Entity,
Expand Down
Loading