fix: implement RegistryServer.Proto gRPC method#6552
Open
nquinn408 wants to merge 1 commit into
Open
Conversation
The remote registry client (RemoteRegistry.proto) calls stub.Proto(Empty()) to fetch the full registry, but the RegistryServer servicer never implemented the Proto RPC, so remote clients received UNIMPLEMENTED. Return proxied_registry.proto(). Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
ntkathole
reviewed
Jun 25, 2026
| self.proxied_registry = registry | ||
|
|
||
| def Proto(self, request: Empty, context) -> RegistryProto: | ||
| return self.proxied_registry.proto() |
Member
There was a problem hiding this comment.
@nquinn408 it was intentionally removed, so that it won't return all information to the users not having access. Probably proper rbac needs to be added if we need it for any purpose.
Contributor
Author
There was a problem hiding this comment.
I understand @ntkathole but then it breaks RemoteRegistry.proto, so I don't know what the solution is. I guess a different implementation for RemoteRegistry.proto?
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I think we can construct the response by calling each typed List* method (have RBAC checks) rather than forwarding the raw proto().
Contributor
Author
There was a problem hiding this comment.
Is there an open issue to address? I will give it a shot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote registry client (RemoteRegistry.proto) calls stub.Proto(Empty()) to fetch the full registry, but the RegistryServer servicer never implemented the Proto RPC, so remote clients received UNIMPLEMENTED. Return proxied_registry.proto().