Skip to content

Backport #647 to v0.4#653

Merged
khorshuheng merged 1 commit intofeast-dev:v0.4-branchfrom
agoda-com:v0.4-backport-647
Apr 27, 2020
Merged

Backport #647 to v0.4#653
khorshuheng merged 1 commit intofeast-dev:v0.4-branchfrom
agoda-com:v0.4-backport-647

Conversation

@ches
Copy link
Copy Markdown
Member

@ches ches commented Apr 26, 2020

What this PR does / why we need it:

Backport the fix for #566, which was already backported earlier.

@ches
Copy link
Copy Markdown
Member Author

ches commented Apr 26, 2020

/assign @pradithya

@khorshuheng
Copy link
Copy Markdown
Collaborator

/lgtm

@khorshuheng
Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ches, khorshuheng
To complete the pull request process, please assign pradithya
You can assign the PR to them by writing /assign @pradithya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng khorshuheng merged commit 90bcdfd into feast-dev:v0.4-branch Apr 27, 2020
@ches ches deleted the v0.4-backport-647 branch May 23, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants