Skip to content

test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
May 29, 2026
Merged

test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) #6450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions sdk/python/tests/unit/test_feature_server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,60 @@ def test_complex_types_are_json_serializable(self):
assert serialized # non-empty


class TestProtobufCompatibility:
"""Regression tests for protobuf >= 7.34.0 compatibility (issue #6435).

protobuf 7.34.0 removed the float_precision kwarg from MessageToDict.
convert_response_to_dict must never call MessageToDict, so it is immune
to this breaking change regardless of the installed protobuf version.
"""

def test_no_message_to_dict_dependency(self):
"""convert_response_to_dict must not call MessageToDict internally."""
import unittest.mock as mock

response = GetOnlineFeaturesResponse()
fv = response.results.add()
fv.values.append(Value(double_val=3.141592653589793))
fv.values.append(Value(int64_val=42))
fv.values.append(Value(string_val="hello"))
fv.statuses.extend(
[FieldStatus.PRESENT, FieldStatus.PRESENT, FieldStatus.PRESENT]
)
response.metadata.feature_names.val.extend(["f1", "f2", "f3"])

with mock.patch(
"google.protobuf.json_format.MessageToDict",
side_effect=AssertionError("MessageToDict must not be called"),
):
result = convert_response_to_dict(response)

assert len(result["results"]) == 1
assert result["results"][0]["values"] == [3.141592653589793, 42, "hello"]
assert result["metadata"]["feature_names"] == ["f1", "f2", "f3"]

def test_double_precision_without_float_precision_kwarg(self):
"""Doubles must round-trip without the removed float_precision kwarg."""
values = [
1e-300,
1.7976931348623157e308,
2.2250738585072014e-308,
0.1 + 0.2,
]
response = GetOnlineFeaturesResponse()
fv = response.results.add()
for v in values:
fv.values.append(Value(double_val=v))
fv.statuses.append(FieldStatus.PRESENT)

result = convert_response_to_dict(response)
for i, expected in enumerate(values):
actual = result["results"][0]["values"][i]
assert actual == expected, f"Mismatch at index {i}: {actual} != {expected}"
round_tripped = json.loads(json.dumps(actual))
assert round_tripped == expected


class TestPerformance:
"""Performance tests to validate the optimization claim."""

Expand Down
Loading