test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435)#6450
Merged
Merged
Conversation
Jwrede
changed the title
ntkathole
approved these changes
May 29, 2026
…t-dev#6435) PR feast-dev#6015 replaced MessageToDict with a custom dict builder in feature_server.py, which incidentally fixed the crash caused by the removed float_precision kwarg in protobuf >= 7.34.0. Add explicit regression tests to prevent reintroduction: - Verify convert_response_to_dict never calls MessageToDict - Verify double precision round-trips without float_precision kwarg Fixes feast-dev#6435 Assisted-by: Claude Opus 4.6 Signed-off-by: Jonathan Wrede <wrede.jonathan00@gmail.com>
ntkathole
force-pushed
the
fix/protobuf-float-precision
branch
from
fec2a08 to
02f200b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds regression tests to guard against reintroduction of the
float_precisionkwarg usage that was removed in PR #6015. TheMessageToDict(float_precision=...)call causedfeature_server.pyto crash on protobuf >= 7.34.0 (see #6435). While the fix landed in #6015, there were no tests preventing reintroduction.Two tests added:
test_no_message_to_dict_dependency-- patchesMessageToDictto raise if called, provingconvert_response_to_dictis independent of ittest_double_precision_without_float_precision_kwarg-- verifies doubles (including edge cases like very small and very large values) round-trip correctly without the removed parameterWhich issue(s) this PR fixes:
Fixes #6435
Checks
git commit -s)Testing Strategy