-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: MLflow distributed tracing for Feast feature server #6405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vperiodt
wants to merge
27
commits into
feast-dev:master
Choose a base branch
from
Vperiodt:mcp-trace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
483e0bc
mlflow-tracing
Vperiodt e89e0a6
cross-process trace
Vperiodt bd1a625
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 4cf9f6e
distributed tracing
Vperiodt 5b3c20c
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 1918d3c
Resolve CI failures in MLflow tracing and MCP server tests
Vperiodt 189c20d
Merge branch 'master' into mcp-trace
Vperiodt 1b54f74
Merge branch 'master' into mcp-trace
Vperiodt 1f6058b
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 2c80822
Merge branch 'master' into mcp-trace
Vperiodt 1164e84
resolve issues
Vperiodt 596c2ab
fix-CI
Vperiodt 31b1416
format
Vperiodt a72e4c5
Merge branch 'master' into mcp-trace
Vperiodt ef12987
add tracing.md
Vperiodt 75c6713
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 41c15bd
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 65ace98
address reviews
Vperiodt 8e3cabc
update pixi.lock
Vperiodt 648ad53
Merge branch 'master' into mcp-trace
Vperiodt fb72cdc
fix-lint
Vperiodt cd839cd
update docs
Vperiodt 5d66d4e
Merge branch 'master' into mcp-trace
Vperiodt c7f541f
fine-tuning export, dataset registry, and tracing enhancements
Vperiodt 7f97666
update pixi
Vperiodt c69a73d
Merge branch 'feast-dev:master' into mcp-trace
Vperiodt 1cb9915
Merge branch 'master' into mcp-trace
Vperiodt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Consider adding opentelemetry-exporter-otlp-proto-http dependency
The mlflow extra includes several OpenTelemetry packages but is missing opentelemetry-exporter-otlp-proto-http which was mentioned in the pixi.lock file. This could cause issues if OTLP export is needed.
Suggested:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that before it was causing grpcio conflicts and
opentelemetry-exporter-otlp-proto-http is already a transitive dep of mlflow>=2.14.0