Skip to content

feat: Add comprehensive Ruff lint configuration #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crawfordxx wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −6
Open

feat: Add comprehensive Ruff lint configuration #6214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,38 @@ tag_regex = "^(?:[\\/\\w-]+)?(?P<version>[vV]?\\d+(?:\\.\\d+){0,2}[^\\+]*)(?:\\+
line-length = 88
target-version = "py310"
include = ["*.py", "*.pyi"]
exclude = [
".eggs",
".git",
".hg",
".mypy_cache",
".tox",
".venv",
"_build",
"buck-out",
"build",
"dist",
"sdk/python/feast/protos",
"sdk/python/feast/embedded_go/lib",
]

[tool.ruff.lint]
select = ["E", "F", "W", "I", "UP"]
ignore = [
"E203", # whitespace before ':'
"E266", # too many leading '#' for block comment
"E501", # line too long (handled by formatter)
"E721", # do not compare types, use isinstance()
]

[tool.ruff.lint.isort]
known-first-party = ["feast", "feast_serving_server", "feast_core_server"]
default-section = "third-party"

[tool.ruff.lint.pyupgrade]
keep-runtime-typing = true

[tool.ruff.format]
# exclude a few common directories in the root of the project
exclude = [
".eggs",
".git",
Expand All @@ -265,10 +294,9 @@ exclude = [
"buck-out",
"build",
"dist",
"pb2.py",
".pyi",
"protos",
"sdk/python/feast/embedded_go/lib"]
"sdk/python/feast/protos",
"sdk/python/feast/embedded_go/lib",
]

[dependency-groups]
dev = [
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@
exclude = [".git","__pycache__","docs/conf.py","dist","feast/protos","feast/embedded_go/lib","feast/infra/utils/snowflake/snowpark/snowflake_udfs.py"]

[tool.ruff.lint]
select = ["E","F","W","I"]
select = ["E", "F", "W", "I", "UP"]
ignore = ["E203", "E266", "E501", "E721"]

[tool.ruff.lint.isort]
known-first-party = ["feast", "feast_serving_server", "feast_core_server"]
default-section = "third-party"

[tool.ruff.lint.pyupgrade]
keep-runtime-typing = true

[tool.mypy]
files = ["feast", "tests"]
ignore_missing_imports = true
Expand Down
Loading