feat: Replace ORJSONResponse with Pydantic response models for faster JSON serialization#6142
Merged
ntkathole merged 1 commit intofeast-dev:masterfrom Mar 23, 2026
Merged
Conversation
… JSON serialization Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ORJSONResponsewith Pydanticresponse_modelon/get-online-featuresand/retrieve-online-documentsendpoints, leveraging FastAPI's native Rust-based JSON serialization via Pydantic V2 for optimal performanceorjsonas a direct dependency frompyproject.toml(and regenerated lock files)[project]with[workspace]ininfra/scripts/pixi/pixi.tomlFastAPI docs recommend using Pydantic
response_modelover custom response classes likeORJSONResponsefor JSON serialization performance:With
response_model, FastAPI serializes directly to JSON bytes via Pydantic's Rust-based serializer skipping thejsonable_encoderintermediate step thatORJSONResponsestill required. Pydantic V2 uses the same underlying Rust mechanisms asorjson, so this is at least as fast while also providing automatic response validation and OpenAPI schema documentation.Which issue(s) this PR fixes:
Fixes #6139