Skip to content

Backport ci changes #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khorshuheng merged 2 commits into from
Apr 7, 2020
Merged

Backport ci changes #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee15d2
Move ci scripts under infra from .prow
khorshuheng Apr 7, 2020
3983476
Backport python test workflow action
khorshuheng Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflow/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: unit tests

on: [push, pull_request]

jobs:
unit-test-python:
runs-on: ubuntu-latest
container: gcr.io/kf-feast/feast-ci:latest
name: unit test python
steps:
- uses: actions/checkout@v1
- name: install python
run: make install-python
- name: test python
run: make test-python
16 changes: 16 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ build-cli:
build-java:
mvn clean verify

# Python SDK

install-python-ci-dependencies:
pip install -r sdk/python/requirements-ci.txt

compile-protos-python: install-python-ci-dependencies
@$(foreach dir,$(PROTO_TYPE_SUBDIRS),cd ${ROOT_DIR}/protos; python -m grpc_tools.protoc -I. --python_out=../sdk/python/ --mypy_out=../sdk/python/ feast/$(dir)/*.proto;)
@$(foreach dir,$(PROTO_SERVICE_SUBDIRS),cd ${ROOT_DIR}/protos; python -m grpc_tools.protoc -I. --grpc_python_out=../sdk/python/ feast/$(dir)/*.proto;)
cd ${ROOT_DIR}/protos; python -m grpc_tools.protoc -I. --python_out=../sdk/python/ --mypy_out=../sdk/python/

install-python: compile-protos-python
pip install -e sdk/python --upgrade

test-python:
pytest --verbose --color=yes sdk/python/tests

build-docker:
docker build -t $(REGISTRY)/feast-core:$(VERSION) -f infra/docker/core/Dockerfile .
docker build -t $(REGISTRY)/feast-serving:$(VERSION) -f infra/docker/serving/Dockerfile .
Expand Down
0 .prow/scripts/download-maven-cache.sh → infra/scripts/download-maven-cache.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/install-google-cloud-sdk.sh → infra/scripts/install-google-cloud-sdk.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/publish-docker-image.sh → infra/scripts/publish-docker-image.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/publish-java-sdk.sh → infra/scripts/publish-java-sdk.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/publish-python-sdk.sh → infra/scripts/publish-python-sdk.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/sync-helm-charts.sh → infra/scripts/sync-helm-charts.sh
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .prow/scripts/test-core-ingestion.sh → infra/scripts/test-core-ingestion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

.prow/scripts/download-maven-cache.sh \
infra/scripts/download-maven-cache.sh \
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
--output-dir /root/

Expand Down
2 changes: 1 addition & 1 deletion .prow/scripts/test-end-to-end-batch.sh → infra/scripts/test-end-to-end-batch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ if [[ ${SKIP_BUILD_JARS} != "true" ]]; then
============================================================
"

.prow/scripts/download-maven-cache.sh \
infra/scripts/download-maven-cache.sh \
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
--output-dir /root/

Expand Down
2 changes: 1 addition & 1 deletion .prow/scripts/test-end-to-end.sh → infra/scripts/test-end-to-end.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ if [[ ${SKIP_BUILD_JARS} != "true" ]]; then
============================================================
"

.prow/scripts/download-maven-cache.sh \
infra/scripts/download-maven-cache.sh \
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
--output-dir /root/

Expand Down
0 .prow/scripts/test-golang-sdk.sh → infra/scripts/test-golang-sdk.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/test-java-sdk.sh → infra/scripts/test-java-sdk.sh
View file
Open in desktop
File renamed without changes.
0 .prow/scripts/test-python-sdk.sh → infra/scripts/test-python-sdk.sh
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .prow/scripts/test-serving.sh → infra/scripts/test-serving.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

.prow/scripts/download-maven-cache.sh \
infra/scripts/download-maven-cache.sh \
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
--output-dir /root/

Expand Down