Skip to content

Backport ci changes#609

Merged
khorshuheng merged 2 commits intofeast-dev:v0.4-branchfrom
khorshuheng:backport-ci-changes
Apr 7, 2020
Merged

Backport ci changes#609
khorshuheng merged 2 commits intofeast-dev:v0.4-branchfrom
khorshuheng:backport-ci-changes

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

@khorshuheng khorshuheng commented Apr 7, 2020 •
edited
Loading

Move CI scripts from .prow to infra

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Apr 7, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khorshuheng
To complete the pull request process, please assign woop
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Apr 7, 2020

This is a lot more than just CI, it also contains Python SDK changes.

@khorshuheng khorshuheng force-pushed the backport-ci-changes branch 2 times, most recently from 1b98653 to 1d77d88 Compare April 7, 2020 08:49
@khorshuheng khorshuheng force-pushed the backport-ci-changes branch from 1d77d88 to 0ee15d2 Compare April 7, 2020 08:55
@khorshuheng
Copy link
Copy Markdown
Collaborator Author

khorshuheng commented Apr 7, 2020

This is a lot more than just CI, it also contains Python SDK changes.

I ended up doing this manually rather than cherry pick the commits, as there are quite a lot of conflicts. I noticed that Python and Golang test no longer appears, not too sure why is that the case though.

@khorshuheng khorshuheng force-pushed the backport-ci-changes branch from 8d9c74b to 0ee15d2 Compare April 7, 2020 10:34
@khorshuheng khorshuheng merged commit dcd95ba into feast-dev:v0.4-branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto davidheryanto is a code owner

@pradithya pradithya Awaiting requested review from pradithya pradithya is a code owner

@woop woop Awaiting requested review from woop woop is a code owner

@zhilingc zhilingc Awaiting requested review from zhilingc zhilingc is a code owner

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khorshuheng @feast-ci-bot @woop