-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Extended OIDC support to extract groups & namespaces and token injection with multiple methods #6089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Extended OIDC support to extract groups & namespaces and token injection with multiple methods #6089
Changes from all commits
5514919
253eb34
9495db0
57deeeb
41522ba
1f4d2d2
8c8e805
dca71da
44a2727
62947e7
19ea1e3
b1bc8df
0bb5c57
c1e5ecf
3320cea
4904257
8be0d21
e32c486
5892ff5
f55fc52
b34ad74
a835465
49294ef
24932db
712a2b9
b9726d5
d141df3
7dfe9fd
1bfe74b
9c26b7b
ca1118c
b51a33f
98a0209
8385a74
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,10 @@ spec: | |
| OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider. | ||
| https://auth0. | ||
| properties: | ||
| secretKeyName: | ||
| description: The key within the Secret that contains the OIDC | ||
| configuration as a YAML-encoded value. | ||
| type: string | ||
| secretRef: | ||
| description: |- | ||
| LocalObjectReference contains enough information to let you locate the | ||
|
|
@@ -76,6 +80,15 @@ spec: | |
| type: string | ||
| type: object | ||
| x-kubernetes-map-type: atomic | ||
| tokenEnvVar: | ||
| description: The name of the environment variable that client | ||
| pods will use to read a pre-existing OIDC token. | ||
|
Comment on lines
+84
to
+85
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you clarify which client pods we are talking about here ? |
||
| type: string | ||
| verifySSL: | ||
| description: |- | ||
| Whether to verify SSL certificates when communicating with the OIDC provider. | ||
| Defaults to true. | ||
| type: boolean | ||
| required: | ||
| - secretRef | ||
| type: object | ||
|
|
@@ -3129,6 +3142,10 @@ spec: | |
| x-kubernetes-validations: | ||
| - message: One selection required. | ||
| rule: '[has(self.local), has(self.remote)].exists_one(c, c)' | ||
| runFeastApplyOnInit: | ||
| description: Runs feast apply on pod start to populate the registry. | ||
| Defaults to true. Ignored when DisableInitContainers is true. | ||
| type: boolean | ||
| scaling: | ||
| description: Scaling configures horizontal scaling for the FeatureStore | ||
| deployment (e.g. HPA autoscaling). | ||
|
|
@@ -5695,7 +5712,6 @@ spec: | |
| type: object | ||
| required: | ||
| - feastProject | ||
| - replicas | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this change from auto-scaling commit. Does this PR need rebase ? |
||
| type: object | ||
| x-kubernetes-validations: | ||
| - message: replicas > 1 and services.scaling.autoscaling are mutually | ||
|
|
@@ -5754,6 +5770,10 @@ spec: | |
| OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider. | ||
| https://auth0. | ||
| properties: | ||
| secretKeyName: | ||
| description: The key within the Secret that contains the | ||
| OIDC configuration as a YAML-encoded value. | ||
| type: string | ||
| secretRef: | ||
| description: |- | ||
| LocalObjectReference contains enough information to let you locate the | ||
|
|
@@ -5768,6 +5788,15 @@ spec: | |
| type: string | ||
| type: object | ||
| x-kubernetes-map-type: atomic | ||
| tokenEnvVar: | ||
| description: The name of the environment variable that | ||
| client pods will use to read a pre-existing OIDC token. | ||
| type: string | ||
| verifySSL: | ||
| description: |- | ||
| Whether to verify SSL certificates when communicating with the OIDC provider. | ||
| Defaults to true. | ||
| type: boolean | ||
| required: | ||
| - secretRef | ||
| type: object | ||
|
|
@@ -8871,6 +8900,11 @@ spec: | |
| - message: One selection required. | ||
| rule: '[has(self.local), has(self.remote)].exists_one(c, | ||
| c)' | ||
| runFeastApplyOnInit: | ||
| description: Runs feast apply on pod start to populate the | ||
| registry. Defaults to true. Ignored when DisableInitContainers | ||
| is true. | ||
| type: boolean | ||
| scaling: | ||
| description: Scaling configures horizontal scaling for the | ||
| FeatureStore deployment (e.g. HPA autoscaling). | ||
|
|
@@ -11458,7 +11492,6 @@ spec: | |
| type: object | ||
| required: | ||
| - feastProject | ||
| - replicas | ||
| type: object | ||
| x-kubernetes-validations: | ||
| - message: replicas > 1 and services.scaling.autoscaling are mutually | ||
|
|
@@ -13920,6 +13953,10 @@ spec: | |
| x-kubernetes-validations: | ||
| - message: One selection required. | ||
| rule: '[has(self.local), has(self.remote)].exists_one(c, c)' | ||
| runFeastApplyOnInit: | ||
| description: Runs feast apply on pod start to populate the registry. | ||
| Defaults to true. Ignored when DisableInitContainers is true. | ||
| type: boolean | ||
| securityContext: | ||
| description: PodSecurityContext holds pod-level security attributes | ||
| and common container settings. | ||
|
|
@@ -18163,6 +18200,11 @@ spec: | |
| - message: One selection required. | ||
| rule: '[has(self.local), has(self.remote)].exists_one(c, | ||
| c)' | ||
| runFeastApplyOnInit: | ||
| description: Runs feast apply on pod start to populate the | ||
| registry. Defaults to true. Ignored when DisableInitContainers | ||
| is true. | ||
| type: boolean | ||
| securityContext: | ||
| description: PodSecurityContext holds pod-level security attributes | ||
| and common container settings. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support OIDC token passing from ODH Notebook instead of service account token ? This we alreayd support for kubernetes token.
Not a blocker though, just for consistency.