feat: Add materialization, feature freshness, request latency, and push metrics to feature server#6071
Merged
ntkathole merged 1 commit intofeast-dev:masterfrom Mar 9, 2026
Merged
Conversation
82d4bf7 to
534688e
Compare
534688e to
6f6ff76
Compare
astefanutti
reviewed
Mar 5, 2026
| metrics: true | ||
| ``` | ||
|
|
||
| The operator automatically exposes port 8000 and creates the corresponding |
There was a problem hiding this comment.
Should the operator also create the PodMonitor / ServiceMonitor resource owned by the FeatureStore resource for Prometheus operator to discover the metrics endpoint and configure the scraping?
Member
Author
There was a problem hiding this comment.
That would be a good enhancement, we can have CRD detection guard to avoid crashing on vanilla Kubernetes clusters without the Prometheus Operator. Will raise an issue for this.
6f6ff76 to
4518b88
Compare
4518b88 to
e8ca946
Compare
e8ca946 to
de33e02
Compare
de33e02 to
7db8e10
Compare
7db8e10 to
18e2786
Compare
franciscojavierarceo
approved these changes
Mar 9, 2026
18e2786 to
34abf5f
Compare
34abf5f to
bec7f4f
Compare
…sh metrics to feature server Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
bec7f4f to
d0cc3dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds rich Prometheus metrics to the Feast feature server covering areas that previously had no observability:
feature_countandfeature_view_countlabels so operators can correlate latency with request complexityPreviously the feature server only had inline CPU/memory monitoring. This PR introduces 10 new metric families covering the full request lifecycle, materialization pipeline, and data freshness.
New metrics
feast_feature_server_request_totalendpoint,statusfeast_feature_server_request_latency_secondsendpoint,feature_count,feature_view_countfeast_online_features_request_totalfeast_online_features_entity_countfeast_push_request_totalpush_source,modefeast_materialization_totalfeature_view,statusfeast_materialization_duration_secondsfeature_viewfeast_feature_freshness_secondsfeature_view,projectfeast_feature_server_cpu_usagefeast_feature_server_memory_usageConfiguration
Metrics are fully opt-in with zero overhead when disabled. Enable via CLI or YAML:
Per-category toggles let disable specific metric groups (e.g., keep CPU/memory but skip request latency). All categories default to true. The --metrics CLI flag works without any YAML config.