Skip to content

Conversation

@samuelkim7
Copy link
Contributor

@samuelkim7 samuelkim7 commented Feb 11, 2026

What this PR does / why we need it:

Adds PostgreSQL online store support for the Go feature server using pgx/v5 with connection pooling.

Changes:

  • postgresonlinestore.go: PostgreSQL online store implementation using pgx/v5 connection pool, batch entity key lookups, schema isolation, and safe credential handling
  • postgresonlinestore_test.go: Unit tests for connection string building, special character handling, constructor initialization, and schema configuration
  • onlinestore.go: Registered "postgres" type in the online store factory
  • go.mod/go.sum: Added github.com/jackc/pgx/v5 dependency

Which issue(s) this PR fixes:

Enables the Go feature server to serve features from the PostgreSQL online store, matching the existing Python SDK capability.

Misc

Follows the same table schema and entity key serialization as the Python PostgreSQL online store.
Verified by running the Go feature server locally in a Docker container and fetching features from a PostgreSQL online store set up in GCP.


Open with Devin

Signed-off-by: samuelkim7 <samuel.kim@goflink.com>
@samuelkim7 samuelkim7 requested a review from a team as a code owner February 11, 2026 22:18
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 6 additional findings in Devin Review.

Open in Devin Review

samuelkim7 and others added 2 commits February 11, 2026 23:42
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: samuelkim7 <samuel.kim@goflink.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: samuelkim7 <samuel.kim@goflink.com>
@samuelkim7 samuelkim7 force-pushed the feat/go-postgres-onlinestore branch from 4945db9 to b25c9c6 Compare February 11, 2026 22:43
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 10 additional findings in Devin Review.

Open in Devin Review

Signed-off-by: samuelkim7 <samuel.kim@goflink.com>
@franciscojavierarceo franciscojavierarceo merged commit b8c6f3d into feast-dev:master Feb 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants