feat: Add per-service scaling & gRPC support #5934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatin5251
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
3 times, most recently
from
e340591 to
f7f7845
Compare
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
from
f7f7845 to
206c701
Compare
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
from
206c701 to
38da893
Compare
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
from
38da893 to
c87e4be
Compare
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
from
c87e4be to
9ff2621
Compare
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
jatin5251
force-pushed
the
feat-feast-operator-mcp-grpc-per-service
branch
from
5ff72f8 to
99b5ca7
Compare
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Member
|
@Srihari1192 Can we please create an image and test these operator changes ? |
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
…:jatin5251/feast into feat-feast-operator-mcp-grpc-per-service
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
ntkathole
requested changes
Feb 5, 2026
| cmd = append(cmd, "--registry_ttl_sec", strconv.Itoa(int(*grpcCfg.RegistryTTLSeconds))) | ||
| } | ||
| } | ||
| if tls := feast.getTlsConfigs(OnlineGrpcFeastType); tls.IsTLS() { |
Member
There was a problem hiding this comment.
feast listen doesn't support --key/--cert options
| }, | ||
| } | ||
| } | ||
| if feast.onlineGrpcOpenshiftTls() { |
Member
There was a problem hiding this comment.
gRPC server has NO TLS support at all and here we are trying to auto-enable broken TLS
ntkathole
reviewed
Feb 5, 2026
| } | ||
|
|
||
| func (feast *FeastServices) setContainers(podSpec *corev1.PodSpec) error { | ||
| func (feast *FeastServices) setContainers(podSpec *corev1.PodSpec, feastType FeastServiceType) error { |
Member
There was a problem hiding this comment.
I see this is breaking change and there is no clear migration path from old deployment to new multiple deployments, single container each.
It keeps the old feast-my-store deployment. After upgrade:
- Old feast-my-store (4 containers) keeps running
- New feast-my-store-* (4-5 deployments) are created
- Both run simultaneously = conflicts, duplicate services, data corruption risks
Member
|
@jatin5251 If possible can we divide the PR into 2 phases, mainly because this contains core architecture changes.
Thoughts? |
ntkathole
reviewed
Feb 5, 2026
| func (feast *FeastServices) mountPvcConfig(podSpec *corev1.PodSpec, pvcConfig *feastdevv1.PvcConfig, feastType FeastServiceType) { | ||
| if podSpec != nil && pvcConfig != nil { | ||
| volName := feast.initPVC(feastType).Name | ||
| volName := feast.initPVC(feast.pvcFeastType(feastType)).Name |
Member
There was a problem hiding this comment.
With separate PVCs, I think it will break file-based persistence. Each pod only has access to its own storage. While materialization with file-based (parquet files), Online pod can't access offline PVC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feature_serverconfig passthrough in the FeatureStore CRD to enable MCP support in the feature server config.Which issue(s) this PR fixes:
(If required i can create Github issue)
Misc