feat: Add HTTP connection pooling for remote online store client #5895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkathole
force-pushed
the
connection_pooling
branch
from
0a20c41 to
e5cb545
Compare
Member
Author
|
FYI - @jyejare |
ntkathole
force-pushed
the
connection_pooling
branch
2 times, most recently
from
5878f9c to
a672d43
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements HTTP connection pooling for the remote online store client to improve performance by reusing TCP/TLS connections across requests. The changes introduce a thread-safe session manager, configurable connection pool settings, and automatic idle timeout management.
Changes:
- Added
HttpSessionManagerclass for thread-safe session caching and connection pooling - Added configurable connection pool settings:
connection_pool_size,connection_idle_timeout, andconnection_retries - Modified session management to use cached sessions instead of context managers
- Added comprehensive test coverage for session management functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/python/feast/permissions/client/http_auth_requests_wrapper.py |
Implements HttpSessionManager with connection pooling, retry logic, and idle timeout |
sdk/python/feast/rest_error_handler.py |
Updates decorator to use cached sessions and extract connection pool config |
sdk/python/feast/infra/online_stores/remote.py |
Adds connection pool config fields and close() method |
sdk/python/tests/unit/permissions/auth/client/test_http_session_manager.py |
Adds comprehensive test suite for session manager |
sdk/python/tests/unit/test_rest_error_decorator.py |
Updates tests to close cached sessions before running |
docs/reference/online-stores/remote.md |
Documents connection pooling configuration and usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"Authorization": f"Bearer {auth_token}"} | ||
| ) | ||
| except Exception as e: | ||
| logger.warning(f"Failed to refresh auth token: {e}") |
There was a problem hiding this comment.
The error message 'Failed to refresh auth token' is logged but the exception is silently swallowed. This could lead to authentication failures being unnoticed. Consider either propagating the exception or providing more context about the consequences of continuing with a potentially stale token.
Suggested change
| logger.warning(f"Failed to refresh auth token: {e}") | |
| logger.warning(f"Failed to refresh auth token: {e}") | |
| raise |
ntkathole
force-pushed
the
connection_pooling
branch
from
a672d43 to
3329678
Compare
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
ntkathole
force-pushed
the
connection_pooling
branch
from
3329678 to
208f00a
Compare
franciscojavierarceo
approved these changes
Jan 26, 2026
franciscojavierarceo
merged commit e022bf8
into
feast-dev:master
24 of 25 checks passed
YassinNouh21
pushed a commit
to YassinNouh21/feast
that referenced
this pull request
Feb 7, 2026
…st-dev#5895) Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
YassinNouh21
pushed a commit
to YassinNouh21/feast
that referenced
this pull request
Feb 7, 2026
…st-dev#5895) Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feature_store.yaml:connection_pool_size,connection_idle_timeout, andconnection_retriesHttpSessionManagerclassMisc
New Features
feature_store.yamlConfiguration Options