fix: Remove upper bound on uvicorn to resolve dependency conflict wit… #5802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h uvicorn-worker The previous constraint `uvicorn[standard]>=0.30.6,<=0.34.0` conflicted with uvicorn-worker 0.4.0 which requires `uvicorn>=0.36.0`. This made it impossible to install Feast with the latest uvicorn-worker version. Removes the upper bound since there are no breaking changes in uvicorn that affect Feast's usage of uvicorn.run() or uvicorn-worker.UvicornWorker. Fixes feast-dev#5677
Member
|
@u-sheikh Please run make lock-python-dependencies-all to update dependencies in requirements |
Regenerated requirements files after removing the upper bound on uvicorn. Now uvicorn 0.40.0 and uvicorn-worker 0.4.0 are compatible.
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h uvicorn-worker
The previous constraint
uvicorn[standard]>=0.30.6,<=0.34.0conflicted with uvicorn-worker 0.4.0 which requiresuvicorn>=0.36.0. This made it impossible to install Feast with the latest uvicorn-worker version.Removes the upper bound since there are no breaking changes in uvicorn that affect Feast's usage of uvicorn.run() or uvicorn-worker.UvicornWorker.
Fixes #5677