Skip to content

fix: Support arro3 table schema with newer deltalake packages #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trollknurr wants to merge 1 commit into from
Closed

fix: Support arro3 table schema with newer deltalake packages #5798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sdk/python/feast/infra/offline_stores/file_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,19 @@ def get_table_column_names_and_types(
"AWS_ENDPOINT_URL": str(self.s3_endpoint_override),
}

schema = (
delta_schema = (
DeltaTable(self.path, storage_options=storage_options)
.schema()
.to_pyarrow()
)
if hasattr(delta_schema, "to_arrow"):
# deltalake >= 0.10.0
arro3_schema = delta_schema.to_arrow()
schema = pyarrow.schema(arro3_schema)
elif hasattr(delta_schema, "to_pyarrow"):
# deltalake < 0.10.0
schema = delta_schema.to_pyarrow()
else:
raise Exception(f"Unknown DeltaTable package version")
else:
raise Exception(f"Unknown FileFormat -> {self.file_format}")

Expand Down