Added: s3_url_style configuration for DuckDB offline store #5597 #5796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables Feast to transmit the s3_url_style='path' parameter to DuckDB during initialization, facilitating compatibility with S3-compatible providers like MinIO and LocalStack that require path-style URL formatting. Changes include: - Add s3_url_style field to DataSource.proto FileOptions - Add s3_url_style field to FeatureService.proto FileDestination - Add staging_location_s3_url_style to DuckDBOfflineStoreConfig - Add s3_url_style to FileSource, FileOptions, SavedDatasetFileStorage, and FileLoggingDestination classes - Create _build_s3_storage_options helper function for consistent storage_options dict construction - Update IbisRetrievalJob to support s3_url_style in to_remote_storage() - Update integration tests to use s3_url_style='path' for MinIO Closes feast-dev#5597
u-sheikh
changed the title
Collaborator
|
It looks like you tried to use newer version of proto lib to generate protos. please try to use the same version. other than that it looks good |
u-sheikh
force-pushed
the
claude/add-robust-feature-EAOTc
branch
from
cecef98 to
b051bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 URL Style Configuration for DuckDB Offline Store
The Problem
When using DuckDB as an offline store with S3-compatible storage systems (like MinIO, LocalStack, or other self-hosted S3 alternatives), authentication failures occur because these systems require a different URL addressing style than AWS S3.
AWS S3 uses two URL styles:
S3-compatible providers like MinIO and LocalStack require path-style URLs, but Feast's DuckDB integration didn't expose this configuration option.
The Solution
This feature adds a new s3_url_style configuration parameter that can be set to "path" to enable path-style URL formatting when communicating with S3-compatible storage.
#5597