Skip to content

feat: Remaining conversion files for v1 API ver #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Dec 15, 2025
Merged

feat: Remaining conversion files for v1 API ver #5777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/feast-operator/bundle.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=feast-operator
LABEL operators.operatorframework.io.bundle.channels.v1=alpha
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.38.0
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.39.1
LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1
LABEL operators.operatorframework.io.metrics.project_layout=go.kubebuilder.io/v4

Expand Down
15 changes: 10 additions & 5 deletions infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
alm-examples: |-
[
{
"apiVersion": "feast.dev/v1alpha1",
"apiVersion": "feast.dev/v1",
"kind": "FeatureStore",
"metadata": {
"name": "sample"
Expand All @@ -15,7 +15,7 @@ metadata:
}
},
{
"apiVersion": "feast.dev/v1alpha1",
"apiVersion": "feast.dev/v1",
"kind": "FeatureStore",
"metadata": {
"name": "sample-remote-servers"
Expand All @@ -36,7 +36,7 @@ metadata:
}
},
{
"apiVersion": "feast.dev/v1alpha1",
"apiVersion": "feast.dev/v1",
"kind": "FeatureStore",
"metadata": {
"name": "sample-ui"
Expand All @@ -50,15 +50,20 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2025-11-13T20:26:23Z"
operators.operatorframework.io/builder: operator-sdk-v1.38.0
createdAt: "2025-12-15T13:55:48Z"
operators.operatorframework.io/builder: operator-sdk-v1.39.1
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.57.0
namespace: placeholder
spec:
apiservicedefinitions: {}
customresourcedefinitions:
owned:
- description: FeatureStore is the Schema for the featurestores API
displayName: Feature Store
kind: FeatureStore
name: featurestores.feast.dev
version: v1
- description: FeatureStore is the Schema for the featurestores API
displayName: Feature Store
kind: FeatureStore
Expand Down
8,277 changes: 8,276 additions & 1 deletion infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion infra/feast-operator/bundle/metadata/annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ annotations:
operators.operatorframework.io.bundle.metadata.v1: metadata/
operators.operatorframework.io.bundle.package.v1: feast-operator
operators.operatorframework.io.bundle.channels.v1: alpha
operators.operatorframework.io.metrics.builder: operator-sdk-v1.38.0
operators.operatorframework.io.metrics.builder: operator-sdk-v1.39.1
operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v4

Expand Down
5 changes: 5 additions & 0 deletions infra/feast-operator/config/manifests/bases/feast-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ spec:
apiservicedefinitions: {}
customresourcedefinitions:
owned:
- description: FeatureStore is the Schema for the featurestores API
displayName: Feature Store
kind: FeatureStore
name: featurestores.feast.dev
version: v1
- description: FeatureStore is the Schema for the featurestores API
displayName: Feature Store
kind: FeatureStore
Expand Down
8 changes: 4 additions & 4 deletions infra/feast-operator/internal/controller/authz/authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"slices"

feastdevv1alpha1 "github.com/feast-dev/feast/infra/feast-operator/api/v1alpha1"
feastdevv1 "github.com/feast-dev/feast/infra/feast-operator/api/v1"
"github.com/feast-dev/feast/infra/feast-operator/internal/controller/services"
rbacv1 "k8s.io/api/rbac/v1"
apimeta "k8s.io/apimachinery/pkg/api/meta"
Expand Down Expand Up @@ -337,15 +337,15 @@ func (authz *FeastAuthorization) getFeastRoleName() string {
return GetFeastRoleName(authz.Handler.FeatureStore)
}

func GetFeastRoleName(featureStore *feastdevv1alpha1.FeatureStore) string {
func GetFeastRoleName(featureStore *feastdevv1.FeatureStore) string {
return services.GetFeastName(featureStore)
}

func (authz *FeastAuthorization) getFeastClusterRoleName() string {
return GetFeastClusterRoleName(authz.Handler.FeatureStore)
}

func GetFeastClusterRoleName(featureStore *feastdevv1alpha1.FeatureStore) string {
func GetFeastClusterRoleName(featureStore *feastdevv1.FeatureStore) string {
// Use a shared ClusterRole name for all Feast instances
// This allows multiple FeatureStores to share the same Token Access Review permissions
return "feast-token-review-cluster-role"
Expand All @@ -355,7 +355,7 @@ func (authz *FeastAuthorization) getFeastClusterRoleBindingName() string {
return GetFeastClusterRoleBindingName(authz.Handler.FeatureStore)
}

func GetFeastClusterRoleBindingName(featureStore *feastdevv1alpha1.FeatureStore) string {
func GetFeastClusterRoleBindingName(featureStore *feastdevv1.FeatureStore) string {
return services.GetFeastName(featureStore) + "-cluster-binding"
}

Expand Down
12 changes: 6 additions & 6 deletions infra/feast-operator/internal/controller/authz/authz_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package authz

import (
feastdevv1alpha1 "github.com/feast-dev/feast/infra/feast-operator/api/v1alpha1"
feastdevv1 "github.com/feast-dev/feast/infra/feast-operator/api/v1"
"github.com/feast-dev/feast/infra/feast-operator/internal/controller/handler"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand All @@ -14,15 +14,15 @@ type FeastAuthorization struct {
var (
feastKubernetesAuthConditions = map[metav1.ConditionStatus]metav1.Condition{
metav1.ConditionTrue: {
Type: feastdevv1alpha1.AuthorizationReadyType,
Type: feastdevv1.AuthorizationReadyType,
Status: metav1.ConditionTrue,
Reason: feastdevv1alpha1.ReadyReason,
Message: feastdevv1alpha1.KubernetesAuthzReadyMessage,
Reason: feastdevv1.ReadyReason,
Message: feastdevv1.KubernetesAuthzReadyMessage,
},
metav1.ConditionFalse: {
Type: feastdevv1alpha1.AuthorizationReadyType,
Type: feastdevv1.AuthorizationReadyType,
Status: metav1.ConditionFalse,
Reason: feastdevv1alpha1.KubernetesAuthzFailedReason,
Reason: feastdevv1.KubernetesAuthzFailedReason,
},
}
)
Loading
Loading