fix: SQLite online store deletes tables from other projects in shared registry scenarios #5766

aniketpalu · 2025-12-08T13:57:46Z

What this PR does / why we need it:

When multiple projects share a SQL registry and the same online store database, applying changes to one project incorrectly deletes tables from other projects.

Root cause analysis

Wrong infra retrieval in plan(): The code used self._registry.proto().infra, which returns infra from the last project processed in the registry (see comment at sql.py:871-873). With multiple projects, this can return another project's infra, causing incorrect diffs.
Missing project filtering in infra diff: The diff_infra_protos() function compared all infra objects without filtering by project. Even if retrieval was correct, if the stored infra contained objects from multiple projects (e.g., from historical data or a bug), the diff would mark other projects' tables for deletion.

Fix

Changed plan() to use self._registry.get_infra(self.project) instead of self._registry.proto().infra to retrieve infra for the current project.
Added project prefix filtering in diff_infra_protos() to only compare infra objects whose names start with {project}_ (table names follow this pattern: {project}_{table_name}).

Which issue(s) this PR fixes:

#5616
RHOAIENG-34863

Misc

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>

aniketpalu · 2025-12-08T14:16:23Z

Test Results: Before vs After Fix

Before Fix (Bug Present)

Test Case 1

Applying real_snake project (shares registry with modern_hermit)
Applying changes for project real_snake
Created sqlite table real_snake_driver_hourly_stats_fresh
Created sqlite table real_snake_driver_hourly_stats
Deleted sqlite table modern_hermit_driver_hourly_stats_fresh ❌ BUG
Deleted sqlite table modern_hermit_driver_hourly_stats ❌ BUG

Test Case 2

Re-applying modern_hermit project
Applying changes for project modern_hermit
No changes to registry
Created sqlite table modern_hermit_driver_hourly_stats_fresh
Created sqlite table modern_hermit_driver_hourly_stats
Deleted sqlite table real_snake_driver_hourly_stats_fresh ❌ BUG
Deleted sqlite table real_snake_driver_hourly_stats ❌ BUG
Issue: Each feast apply deletes tables from the other project sharing the same registry.

Terminal Output

(dev) apaluska@apaluska-mac feast % feast init

Creating a new Feast repository in /Users/apaluska/Work/feast/modern_hermit.

(dev) apaluska@apaluska-mac feast % feast init

Creating a new Feast repository in /Users/apaluska/Work/feast/real_snake.

(dev) apaluska@apaluska-mac feast % cd modern_hermit/feature_repo; feast apply;
/Users/apaluska/Work/feast/modern_hermit/feature_repo/example_repo.py:27: DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity 'driver'.
  driver = Entity(name="driver", join_keys=["driver_id"])
Applying changes for project modern_hermit
/Users/apaluska/Work/feast/sdk/python/feast/feature_store.py:583: RuntimeWarning: On demand feature view is an experimental feature. This API is stable, but the functionality does not scale well for offline retrieval
  warnings.warn(
Created project modern_hermit
Created entity driver
Created feature view driver_hourly_stats
Created feature view driver_hourly_stats_fresh
Created on demand feature view transformed_conv_rate
Created on demand feature view transformed_conv_rate_fresh
Created feature service driver_activity_v3
Created feature service driver_activity_v1
Created feature service driver_activity_v2

Created sqlite table modern_hermit_driver_hourly_stats_fresh
Created sqlite table modern_hermit_driver_hourly_stats

(dev) apaluska@apaluska-mac feature_repo % cd ../../modern_hermit/feature_repo; cat feature_store.yaml 
project: modern_hermit
# By default, the registry is a file (but can be turned into a more scalable SQL-backed registry)
registry: data/registry.db
# The provider primarily specifies default offline / online stores & storing the registry in a given cloud
provider: local
online_store:
    type: sqlite
    path: data/online_store.db
entity_key_serialization_version: 3
# By default, no_auth for authentication and authorization, other possible values kubernetes and oidc. Refer the documentation for more details.
auth:
    type: no_auth
(dev) apaluska@apaluska-mac feature_repo % cd ../../real_snake/feature_repo; cat feature_store.yaml 
project: real_snake
# By default, the registry is a file (but can be turned into a more scalable SQL-backed registry)
registry: /Users/apaluska/Work/feast/modern_hermit/feature_repo/data/registry.db
# The provider primarily specifies default offline / online stores & storing the registry in a given cloud
provider: local
online_store:
    type: sqlite
    path: data/online_store.db
entity_key_serialization_version: 3
# By default, no_auth for authentication and authorization, other possible values kubernetes and oidc. Refer the documentation for more details.
auth:
    type: no_auth
(dev) apaluska@apaluska-mac feature_repo % feast apply
/Users/apaluska/Work/feast/real_snake/feature_repo/example_repo.py:27: DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity 'driver'.
  driver = Entity(name="driver", join_keys=["driver_id"])
Applying changes for project real_snake
/Users/apaluska/Work/feast/sdk/python/feast/feature_store.py:583: RuntimeWarning: On demand feature view is an experimental feature. This API is stable, but the functionality does not scale well for offline retrieval
  warnings.warn(
Created project real_snake
Created entity driver
Created feature view driver_hourly_stats
Created feature view driver_hourly_stats_fresh
Created on demand feature view transformed_conv_rate
Created on demand feature view transformed_conv_rate_fresh
Created feature service driver_activity_v2
Created feature service driver_activity_v3
Created feature service driver_activity_v1

Created sqlite table real_snake_driver_hourly_stats_fresh
Created sqlite table real_snake_driver_hourly_stats
Deleted sqlite table modern_hermit_driver_hourly_stats_fresh
Deleted sqlite table modern_hermit_driver_hourly_stats

(dev) apaluska@apaluska-mac feature_repo % cd ../../modern_hermit/feature_repo; feast apply
/Users/apaluska/Work/feast/modern_hermit/feature_repo/example_repo.py:27: DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity 'driver'.
  driver = Entity(name="driver", join_keys=["driver_id"])
Applying changes for project modern_hermit
/Users/apaluska/Work/feast/sdk/python/feast/feature_store.py:583: RuntimeWarning: On demand feature view is an experimental feature. This API is stable, but the functionality does not scale well for offline retrieval
  warnings.warn(
No changes to registry
Created sqlite table modern_hermit_driver_hourly_stats_fresh
Created sqlite table modern_hermit_driver_hourly_stats
Deleted sqlite table real_snake_driver_hourly_stats_fresh
Deleted sqlite table real_snake_driver_hourly_stats

After Fix (Bug Resolved)

Test Case 1

Applying fit_impala project
Applying changes for project fit_impala
Created sqlite table fit_impala_driver_hourly_stats_fresh
Created sqlite table fit_impala_driver_hourly_stats ✅ No deletions of other projects' tables

Test Case 2: Applying premium_dory project (shares registry with fit_impala)

Applying changes for project premium_dory
Created sqlite table premium_dory_driver_hourly_stats_fresh
Created sqlite table premium_dory_driver_hourly_stats ✅ No deletions of fit_impala tables
Result: Projects sharing a registry no longer delete each other's tables. Each project only manages its own infrastructure.

Terminal Output

(dev) apaluska@apaluska-mac feast % feast init
feast i
Creating a new Feast repository in /Users/apaluska/Work/feast/fit_impala.

ni%                                                                                                                 
(dev) apaluska@apaluska-mac feast % feast init

Creating a new Feast repository in /Users/apaluska/Work/feast/premium_dory.

(dev) apaluska@apaluska-mac feast % cd fit_impala/feature_repo; feast apply
/Users/apaluska/Work/feast/fit_impala/feature_repo/example_repo.py:27: DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity 'driver'.
  driver = Entity(name="driver", join_keys=["driver_id"])
Applying changes for project fit_impala
/Users/apaluska/Work/feast/sdk/python/feast/feature_store.py:583: RuntimeWarning: On demand feature view is an experimental feature. This API is stable, but the functionality does not scale well for offline retrieval
  warnings.warn(
Created project fit_impala
Created entity driver
Created feature view driver_hourly_stats_fresh
Created feature view driver_hourly_stats
Created on demand feature view transformed_conv_rate_fresh
Created on demand feature view transformed_conv_rate
Created feature service driver_activity_v3
Created feature service driver_activity_v1
Created feature service driver_activity_v2

Created sqlite table fit_impala_driver_hourly_stats_fresh
Created sqlite table fit_impala_driver_hourly_stats

(dev) apaluska@apaluska-mac feature_repo % 
(dev) apaluska@apaluska-mac feature_repo % 
(dev) apaluska@apaluska-mac feature_repo % 
(dev) apaluska@apaluska-mac feature_repo % cd ../../premium_dory/feature_repo; cat feature_store.yaml  
project: premium_dory
# By default, the registry is a file (but can be turned into a more scalable SQL-backed registry)
registry: **/Users/apaluska/Work/feast/fit_impala/feature_repo/data/registry.db**
# The provider primarily specifies default offline / online stores & storing the registry in a given cloud
provider: local
online_store:
    type: sqlite
    path: data/online_store.db
entity_key_serialization_version: 3
# By default, no_auth for authentication and authorization, other possible values kubernetes and oidc. Refer the documentation for more details.
auth:
    type: no_auth
(dev) apaluska@apaluska-mac feature_repo % feast apply
/Users/apaluska/Work/feast/premium_dory/feature_repo/example_repo.py:27: DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity 'driver'.
  driver = Entity(name="driver", join_keys=["driver_id"])
Applying changes for project premium_dory
/Users/apaluska/Work/feast/sdk/python/feast/feature_store.py:583: RuntimeWarning: On demand feature view is an experimental feature. This API is stable, but the functionality does not scale well for offline retrieval
  warnings.warn(
Created project premium_dory
Created entity driver
Created feature view driver_hourly_stats_fresh
Created feature view driver_hourly_stats
Created on demand feature view transformed_conv_rate_fresh
Created on demand feature view transformed_conv_rate
Created feature service driver_activity_v2
Created feature service driver_activity_v3
Created feature service driver_activity_v1

**Created sqlite table premium_dory_driver_hourly_stats_fresh
Created sqlite table premium_dory_driver_hourly_stats**

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>

ntkathole

Looks good

# [0.58.0](v0.57.0...v0.58.0) (2025-12-16) ### Bug Fixes * Add java proto ([#5719](#5719)) ([fc3ea20](fc3ea20)) * Add possibility to force full features names for materialize ops ([#5728](#5728)) ([55c9c36](55c9c36)) * Fixed file registry cache sync ([09505d4](09505d4)) * Handle hyphon in sqlite project name ([#5575](#5575)) ([#5749](#5749)) ([b8346ff](b8346ff)) * Pinned substrait to fix protobuf issue ([d0ef4da](d0ef4da)) * Set TLS certificate annotation only on gRPC service ([#5715](#5715)) ([75d13db](75d13db)) * SQLite online store deletes tables from other projects in shared registry scenarios ([#5766](#5766)) ([fabce76](fabce76)) * Validate not existing entity join keys for preventing panic ([0b93559](0b93559)) ### Features * Add annotations for pod templates ([534e647](534e647)) * Add Pytorch template ([#5780](#5780)) ([6afd353](6afd353)) * Add support for extra options for stream source ([#5618](#5618)) ([18956c2](18956c2)) * Added matched_tag field search api results with fuzzy search capabilities ([#5769](#5769)) ([4a9ffae](4a9ffae)) * Added support for enabling metrics in Feast Operator ([#5317](#5317)) ([#5748](#5748)) ([a8498c2](a8498c2)) * Configure CacheTTLSecondscache,CacheMode for file-based registry in Feast Operator([#5708](#5708)) ([#5744](#5744)) ([f25f83b](f25f83b)) * Implemented Tiling Support for Time-Windowed Aggregations ([#5724](#5724)) ([7a99166](7a99166)) * Offline Store historical features retrieval based on datetime range for spark ([#5720](#5720)) ([27ec8ec](27ec8ec)) * Offline Store historical features retrieval based on datetime range in dask ([#5717](#5717)) ([a16582a](a16582a)) * Production ready feast operator with v1 apiversion ([#5771](#5771)) ([49359c6](49359c6)) * Support for Map value data type ([#5768](#5768)) ([#5772](#5772)) ([b99a8a9](b99a8a9))

Added project prefix filtering when getting infra difference

271c4ef

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>

aniketpalu requested a review from a team as a code owner December 8, 2025 13:57

Merge branch 'master' into RHOAIENG-34863

c51063f

Minoring formatting changes

833a610

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>

ntkathole added the ok-to-test label Dec 9, 2025

ntkathole approved these changes Dec 10, 2025

View reviewed changes

ntkathole merged commit fabce76 into feast-dev:master Dec 10, 2025
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: SQLite online store deletes tables from other projects in shared registry scenarios #5766

fix: SQLite online store deletes tables from other projects in shared registry scenarios #5766

Uh oh!

aniketpalu commented Dec 8, 2025

Uh oh!

aniketpalu commented Dec 8, 2025 •

edited

Loading

Uh oh!

ntkathole left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: SQLite online store deletes tables from other projects in shared registry scenarios #5766

fix: SQLite online store deletes tables from other projects in shared registry scenarios #5766

Uh oh!

Conversation

aniketpalu commented Dec 8, 2025

What this PR does / why we need it:

Root cause analysis

Fix

Which issue(s) this PR fixes:

Misc

Uh oh!

aniketpalu commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results: Before vs After Fix

Before Fix (Bug Present)

Test Case 1

Test Case 2

Terminal Output

After Fix (Bug Resolved)

Test Case 1

Test Case 2: Applying premium_dory project (shares registry with fit_impala)

Terminal Output

Uh oh!

ntkathole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aniketpalu commented Dec 8, 2025 •

edited

Loading