Skip to content

fix: Validate not existing entity join keys for preventing panic #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Dec 7, 2025
Merged

fix: Validate not existing entity join keys for preventing panic #5763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion go/internal/feast/onlineserving/serving.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ func ValidateEntityValues(joinKeyValues map[string]*prototypes.RepeatedValue,
requestData map[string]*prototypes.RepeatedValue,
expectedJoinKeysSet map[string]interface{}) (int, error) {
numRows := -1

if err := validateJoinKeys(joinKeyValues, expectedJoinKeysSet); err != nil {
return -1, errors.New("valueError: " + err.Error())
}
for joinKey, values := range joinKeyValues {
if _, ok := expectedJoinKeysSet[joinKey]; !ok {
requestData[joinKey] = values
Expand Down Expand Up @@ -647,6 +649,17 @@ func getQualifiedFeatureName(viewName string, featureName string, fullFeatureNam
}
}

func validateJoinKeys(
joinKeyValues map[string]*prototypes.RepeatedValue,
expectedJoinKeysSet map[string]interface{}) error {
for joinKey, _ := range joinKeyValues {
if _, ok := expectedJoinKeysSet[joinKey]; !ok {
return fmt.Errorf("Invalid entity join key. key=%s", joinKey)
}
}
return nil
}

type featureNameCollisionError struct {
featureRefCollisions []string
fullFeatureNames bool
Expand Down
Loading