Skip to content

Revert "Fix runner to string inconsistency"#576

Closed
mrzzy wants to merge 1 commit intofeast-dev:masterfrom
mrzzy:revert-575-fix-runner-to-string-inconsistency
Closed

Revert "Fix runner to string inconsistency"#576
mrzzy wants to merge 1 commit intofeast-dev:masterfrom
mrzzy:revert-575-fix-runner-to-string-inconsistency

Conversation

@mrzzy
Copy link
Copy Markdown
Collaborator

@mrzzy mrzzy commented Mar 27, 2020

Reverts #575

I introduced a bug in one of the commits in the PR.
Reverts the PR until I fix the bug.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrzzy
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

Hi @mrzzy. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrzzy mrzzy closed this Mar 27, 2020
@mrzzy mrzzy reopened this Mar 27, 2020
@mrzzy mrzzy closed this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants