Skip to content

fix: Handle hyphon in sqlite project name (#5575) #5749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Dec 2, 2025
Merged

fix: Handle hyphon in sqlite project name (#5575) #5749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d424e
fix: handle hyphon in sqlite project name (#5575)
jfw-ppi Nov 29, 2025
1ac5c8e
fix: handle hyphon in sqlite project name ([#5575](https://github.com…
jfw-ppi Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion sdk/python/feast/repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@ def _validate_online_store_config(cls, values: Any) -> Any:
online_config_class(**values["online_store"])
except ValidationError as e:
raise e

return values

@model_validator(mode="before")
Expand Down Expand Up @@ -502,14 +503,28 @@ def _validate_feature_server_config(cls, values: Any) -> Any:

@field_validator("project")
@classmethod
def _validate_project_name(cls, v: str) -> str:
def _validate_project_name(cls, v: str, info: ValidationInfo) -> str:
# Deferred import to avoid circular dependency during package initialization.
from feast.repo_operations import is_valid_name

sqlite_compatible = False

online_store = info.data.get("online_store") if info else None
if online_store is None or online_store == {}:
sqlite_compatible = True
elif isinstance(online_store, dict):
sqlite_compatible = online_store.get("type", "sqlite") == "sqlite"

if not is_valid_name(v):
raise ValueError(
f"Project name, {v}, should only have "
f"alphanumerical values, underscores, and hyphens but not start with an underscore or hyphen."
)

if sqlite_compatible and "-" in v:
raise ValueError(
"Project names for SQLite online stores cannot contain hyphens because they are used in table names."
)
return v

@field_validator("flags")
Expand Down
Loading