Skip to content

feat: Production ready feast operator with v1 apiversion #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyejare wants to merge 1 commit into from
Closed

feat: Production ready feast operator with v1 apiversion #5743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/how-to-guides/running-feast-in-production.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ kubectl apply -f https://raw.githubusercontent.com/feast-dev/feast/refs/tags/<ve
3. Deploy a Feature Store

```sh
kubectl apply -f https://raw.githubusercontent.com/feast-dev/feast/refs/heads/stable/infra/feast-operator/config/samples/v1alpha1_featurestore.yaml
kubectl apply -f https://raw.githubusercontent.com/feast-dev/feast/refs/heads/stable/infra/feast-operator/config/samples/v1_featurestore.yaml
```
Verify the status
```
Expand All @@ -238,7 +238,7 @@ sample Ready 2m21s

The above will install a simple [FeatureStore CR](../../infra/feast-operator/docs/api/markdown/ref.md) like the following. By default, it will run the [Online Store feature server](../reference/feature-servers/python-feature-server.md) -
```yaml
apiVersion: feast.dev/v1alpha1
apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
name: sample
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/feature-servers/offline-feature-server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ See [this](../../how-to-guides/running-feast-in-production.md#id-4.2.-deploy-fea

The Offline feature server can be deployed with a slight modification of the FeatureStore CR -
```yaml
apiVersion: feast.dev/v1alpha1
apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
name: sample-offline-server
Expand Down
16 changes: 8 additions & 8 deletions examples/operator-postgres-tls-demo/02-Install-feast.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@
"\n",
"When connecting to PostgreSQL with TLS, some important parameters in the connection URL are: \n",
"\n",
"- **`sslrootcert`** – Specifies the path to the **CA certificate** file used to validate trusted certificates. \n",
"- **`sslcert`** – Provides the client certificate for **mutual TLS (mTLS) encryption**. \n",
"- **`sslkey`** – Specifies the private key for the client certificate. \n",
"- **`sslrootcert`** \u2013 Specifies the path to the **CA certificate** file used to validate trusted certificates. \n",
"- **`sslcert`** \u2013 Provides the client certificate for **mutual TLS (mTLS) encryption**. \n",
"- **`sslkey`** \u2013 Specifies the private key for the client certificate. \n",
"\n",
"If mutual TLS authentication is not required, you can **omit** the `sslcert` and `sslkey` parameters. However, the `sslrootcert` parameter is still necessary for validating server certificates. \n"
]
Expand All @@ -110,7 +110,7 @@
"\n",
"In this approach, we specify the CA certificate path directly in the Feast PostgreSQL URL using the `sslrootcert` parameter. \n",
"\n",
"You can refer to the `v1alpha1_featurestore_postgres_db_volumes_tls.yaml` file for the complete configuration details. "
"You can refer to the `v1_featurestore_postgres_db_volumes_tls.yaml` file for the complete configuration details. "
]
},
{
Expand All @@ -131,7 +131,7 @@
}
],
"source": [
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_tls.yaml --namespace=feast"
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1_featurestore_postgres_db_volumes_tls.yaml --namespace=feast"
]
},
{
Expand All @@ -140,7 +140,7 @@
"source": [
"**Option 2: Using an Environment Variable for the CA Certificate** \n",
"\n",
"In this approach, you define the CA certificate path as an environment variable. You can refer to the `v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml` file for the complete configuration details. \n",
"In this approach, you define the CA certificate path as an environment variable. You can refer to the `v1_featurestore_postgres_tls_volumes_ca_env.yaml` file for the complete configuration details. \n",
"\n",
"```bash\n",
"FEAST_CA_CERT_FILE_PATH=<path-to-ca-cert>\n"
Expand All @@ -162,7 +162,7 @@
}
],
"source": [
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml --namespace=feast"
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1_featurestore_postgres_tls_volumes_ca_env.yaml --namespace=feast"
]
},
{
Expand Down Expand Up @@ -455,4 +455,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
12 changes: 6 additions & 6 deletions examples/operator-postgres-tls-demo/03-Uninstall.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@
"secret \"postgres-secret\" deleted\n",
"secret \"feast-data-stores\" deleted\n",
"featurestore.feast.dev \"sample-db-ssl\" deleted\n",
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml\": secrets \"postgres-secret\" not found\n",
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml\": secrets \"feast-data-stores\" not found\n",
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml\": featurestores.feast.dev \"sample-db-ssl\" not found\n"
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1_featurestore_postgres_tls_volumes_ca_env.yaml\": secrets \"postgres-secret\" not found\n",
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1_featurestore_postgres_tls_volumes_ca_env.yaml\": secrets \"feast-data-stores\" not found\n",
"Error from server (NotFound): error when deleting \"../../infra/feast-operator/config/samples/v1_featurestore_postgres_tls_volumes_ca_env.yaml\": featurestores.feast.dev \"sample-db-ssl\" not found\n"
]
}
],
"source": [
"# If you have choosen the option 1 example earlier.\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_tls.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1_featurestore_postgres_db_volumes_tls.yaml\n",
"\n",
"# If you have choosen the option 2 example earlier.\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_tls_volumes_ca_env.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1_featurestore_postgres_tls_volumes_ca_env.yaml\n",
"\n",
"#!kubectl delete -f ../../infra/feast-operator/dist/install.yaml"
]
Expand Down Expand Up @@ -131,4 +131,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
2 changes: 1 addition & 1 deletion examples/operator-quickstart/feast.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ stringData:
echo: false
pool_pre_ping: true
---
apiVersion: feast.dev/v1alpha1
apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
name: example
Expand Down
10 changes: 5 additions & 5 deletions examples/operator-rbac-openshift-tls/1-setup-operator-rbac.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"metadata": {},
"source": [
"## Install the Feast services via FeatureStore CR\n",
"Next, we'll use the running Feast Operator to install the feast services with Server components online, offline, registry with kubernetes Authorization set. Apply the included [reference deployment](../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml) to install and configure Feast with kubernetes Authorization ."
"Next, we'll use the running Feast Operator to install the feast services with Server components online, offline, registry with kubernetes Authorization set. Apply the included [reference deployment](../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml) to install and configure Feast with kubernetes Authorization ."
]
},
{
Expand All @@ -177,7 +177,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"apiVersion: feast.dev/v1alpha1\n",
"apiVersion: feast.dev/v1\n",
"kind: FeatureStore\n",
"metadata:\n",
" name: sample-kubernetes-auth\n",
Expand All @@ -202,8 +202,8 @@
}
],
"source": [
"!cat ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml\n",
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml -n feast"
"!cat ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml\n",
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml -n feast"
]
},
{
Expand Down Expand Up @@ -738,4 +738,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
4 changes: 2 additions & 2 deletions examples/operator-rbac-openshift-tls/3-uninstall.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
],
"source": [
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/dist/install.yaml"
]
},
Expand Down Expand Up @@ -218,4 +218,4 @@
},
"nbformat": 4,
"nbformat_minor": 5
}
}
4 changes: 2 additions & 2 deletions examples/operator-rbac/04-uninstall.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
],
"source": [
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml\n",
"!kubectl delete -f ../../infra/feast-operator/dist/install.yaml"
]
},
Expand Down Expand Up @@ -216,4 +216,4 @@
},
"nbformat": 4,
"nbformat_minor": 5
}
}
10 changes: 5 additions & 5 deletions examples/operator-rbac/1-setup-operator-rbac.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"metadata": {},
"source": [
"## Install the Feast services via FeatureStore CR\n",
"Next, we'll use the running Feast Operator to install the feast services with Server components online, offline, registry with kubernetes Authorization set. Apply the included [reference deployment](../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml) to install and configure Feast with kubernetes Authorization ."
"Next, we'll use the running Feast Operator to install the feast services with Server components online, offline, registry with kubernetes Authorization set. Apply the included [reference deployment](../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml) to install and configure Feast with kubernetes Authorization ."
]
},
{
Expand All @@ -194,7 +194,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"apiVersion: feast.dev/v1alpha1\n",
"apiVersion: feast.dev/v1\n",
"kind: FeatureStore\n",
"metadata:\n",
" name: sample-kubernetes-auth\n",
Expand All @@ -219,8 +219,8 @@
}
],
"source": [
"!cat ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml\n",
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1alpha1_featurestore_kubernetes_auth.yaml -n feast"
"!cat ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml\n",
"!kubectl apply -f ../../infra/feast-operator/config/samples/v1_featurestore_kubernetes_auth.yaml -n feast"
]
},
{
Expand Down Expand Up @@ -761,4 +761,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
2 changes: 1 addition & 1 deletion infra/feast-operator/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ $(CRD_REF_DOCS): $(LOCALBIN)

.PHONY: generate-ref
generate-ref: generate fmt crd-ref-docs
$(CRD_REF_DOCS) --log-level=WARN --max-depth=30 --config=$(LOCALDIR)/docs/crd-ref-templates/config.yaml --source-path=$(LOCALDIR)/api/v1alpha1 --renderer=markdown --templates-dir=$(LOCALDIR)/docs/crd-ref-templates/markdown --output-path=$(LOCALDIR)/docs/api/markdown/ref.md
$(CRD_REF_DOCS) --log-level=WARN --max-depth=30 --config=$(LOCALDIR)/docs/crd-ref-templates/config.yaml --source-path=$(LOCALDIR)/api/v1 --renderer=markdown --templates-dir=$(LOCALDIR)/docs/crd-ref-templates/markdown --output-path=$(LOCALDIR)/docs/api/markdown/ref.md

.PHONY: bundle
bundle: manifests kustomize related-image-fs operator-sdk ## Generate bundle manifests and metadata, then validate generated files.
Expand Down
4 changes: 2 additions & 2 deletions infra/feast-operator/PROJECT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ resources:
controller: true
domain: feast.dev
kind: FeatureStore
path: github.com/feast-dev/feast/infra/feast-operator/api/v1alpha1
version: v1alpha1
path: github.com/feast-dev/feast/infra/feast-operator/api/v1
version: v1
version: "3"
2 changes: 1 addition & 1 deletion ...erator/api/v1alpha1/featurestore_types.go → ...ast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package v1alpha1
package v1

import (
appsv1 "k8s.io/api/apps/v1"
Expand Down
6 changes: 3 additions & 3 deletions ...perator/api/v1alpha1/groupversion_info.go → ...east-operator/api/v1/groupversion_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// Package v1alpha1 contains API Schema definitions for the v1alpha1 API group
// Package v1 contains API Schema definitions for the v1 API group
// +kubebuilder:object:generate=true
// +groupName=feast.dev
package v1alpha1
package v1

import (
"k8s.io/apimachinery/pkg/runtime/schema"
Expand All @@ -26,7 +26,7 @@ import (

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "feast.dev", Version: "v1alpha1"}
GroupVersion = schema.GroupVersion{Group: "feast.dev", Version: "v1"}

// SchemeBuilder is used to add go types to the GroupVersionKind scheme
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}
Expand Down
Loading
Loading