fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore #5703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RemoteOfflineStore Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
… entity_df in offline server Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
ntkathole
approved these changes
Oct 30, 2025
Member
ntkathole
left a comment
ntkathole
left a comment
There was a problem hiding this comment.
Looks good! @aniketpalu can you please rebase to resolve conflicts ?
jyejare
suggested changes
Nov 2, 2025
Contributor
jyejare
left a comment
jyejare
left a comment
There was a problem hiding this comment.
Handle empty entity_df in offline server.
sdk/python/feast/offline_server.py
Outdated
| datetime.fromisoformat(command["start_date"]) | ||
| ) | ||
| end_date = utils.make_tzaware(datetime.fromisoformat(command["end_date"])) | ||
| entity_df = pd.DataFrame( |
Contributor
There was a problem hiding this comment.
We should not need to create dummy entity_df at all. We should handle empty(entity_df=None) entity_df for and in offline_store.get_historical_features which we are returning in this function.
Contributor
Author
There was a problem hiding this comment.
You are right, its not needed to create mock dataframe with timestamps, just had to make sure that empty_df is being passed.
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
jyejare
approved these changes
Nov 3, 2025
franciscojavierarceo
pushed a commit
that referenced
this pull request
Nov 13, 2025
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13) ### Bug Fixes * Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2)) * Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3)) * Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756)) * Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed)) ### Features * Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2)) * Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb)) * Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72)) * Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Problem
Root Cause
Changes
Which issue(s) this PR fixes:
Misc