Skip to content

Conversation

@blaketastic2
Copy link
Contributor

@blaketastic2 blaketastic2 commented Oct 17, 2025

What this PR does / why we need it:

  • Introduces a new commandArgs parameter that allows complete control over Feast CLI command-line arguments
  • Maintains full backward compatibility with existing configurations through fallback logic
  • Enables access to all Feast CLI options including previously unavailable ones like --root_path, --registry_ttl_sec, custom ports, and future options
  • Provides comprehensive documentation and examples for all Feast deployment modes
    Creates a future-proof solution that doesn't require template updates for new Feast CLI features

The current Feast Helm chart limits configurability by hardcoding CLI arguments. This creates several problems:

  • Missing Functionality: Users cannot access many Feast CLI options (e.g., --root_path for UI proxy support, --registry_ttl_sec for registry refresh control)
  • Maintenance Burden: Every new Feast CLI option requires template modifications and chart updates
    Inflexibility: Complex deployment scenarios requiring custom argument ordering or conditional options are impossible
  • User Workarounds: Forces users to fork charts or use suboptimal configurations

This PR allows for flexible, comprehensive solution that will grow with Feast's capabilities while preserving existing functionality.

Which issue(s) this PR fixes:

None

Misc

None

Signed-off-by: Blake <blaketastic2@gmail.com>
@blaketastic2 blaketastic2 requested a review from a team as a code owner October 17, 2025 12:54
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Blake <blaketastic2@gmail.com>
@franciscojavierarceo franciscojavierarceo merged commit 6414924 into feast-dev:master Oct 17, 2025
19 of 20 checks passed
@blaketastic2 blaketastic2 deleted the blake/helm-command-args branch October 17, 2025 16:09
shuchu pushed a commit to shuchu/feast that referenced this pull request Oct 21, 2025
…feast-dev#5678)

* feat: Add flexible commandArgs support for complete Feast CLI control

Signed-off-by: Blake <blaketastic2@gmail.com>

* missed trailing pipe

Signed-off-by: Blake <blaketastic2@gmail.com>

---------

Signed-off-by: Blake <blaketastic2@gmail.com>
franciscojavierarceo pushed a commit that referenced this pull request Oct 27, 2025
# [0.56.0](v0.55.0...v0.56.0) (2025-10-27)

### Bug Fixes

* Add mode field to Transformation proto for proper serialization ([2390d2e](2390d2e))
* Date wise remote offline store historical data retrieval  ([#5686](#5686)) ([949ba3d](949ba3d))
* Fix STRING type handling in on-demand feature views ([#5669](#5669)) ([dfbb743](dfbb743))
* Fixed torch install issue in CI ([366e5a8](366e5a8))
* ODFV not getting counted in resource count ([1d640b6](1d640b6))
* Skip tag updates if user do not have permissions ([#5673](#5673)) ([0a951ce](0a951ce))

### Features

* Add document of Go feature server. ([#5697](#5697)) ([cbd1dde](cbd1dde))
* Add flexible commandArgs support for complete Feast CLI control ([#5678](#5678)) ([6414924](6414924))
* Add HDFS as a feature registry ([#5655](#5655)) ([4c65872](4c65872))
* Add nodeSelector to service config ([#5675](#5675)) ([9728cde](9728cde))
* Add OTEL based observability to the Go Feature Server ([#5685](#5685)) ([f4afdad](f4afdad))
* Added health endpoint for the UI ([#5665](#5665)) ([3aec5d5](3aec5d5))
* Added kuberay support ([e0b698d](e0b698d))
* Added support for filtering multi-projects ([#5688](#5688)) ([eb0a86e](eb0a86e))
* Batch Embedding at scale for RAG with Ray ([cc2a46d](cc2a46d))
* Optimize SQL entity handling without creating temporary tables ([#5695](#5695)) ([aa2c838](aa2c838))
* Support aggregation in odfv ([#5666](#5666)) ([564e965](564e965))
* Support cache_mode for registries ([021e9ea](021e9ea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants