-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: Loosen pyarrow #5661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Loosen pyarrow #5661
Conversation
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update setup.py and then run make install-python-dependencies-dev?
Signed-off-by: dlovell <dlovell@gmail.com>
Signed-off-by: dlovell <dlovell@gmail.com>
4c06ac4 to
d56c8f6
Compare
|
hmm looks like macos-14 doesn't like it @ntkathole can you provide some guidance here? |
|
i'm not sure i created my venv with i'll start over with a venv created that way |
|
looks like |
The requirement file included in PR has nvidia-* dependencies which is only meant for GPU supported systems. You need to make sure |
|
Also, fyi - we have APACHE_ARROW_VERSION="17.0.0" added in feast-operator images, which needs to be updated as well. |
3777db6 to
7a46e80
Compare
|
@ntkathole FYI: i've modified its not clear that |
Signed-off-by: dlovell <dlovell@gmail.com>
7a46e80 to
af98a25
Compare
Looks like it is appending
I see, right. No need to update since it's still pin to 17.0.0 |
Signed-off-by: dlovell <dlovell@gmail.com>
af98a25 to
e8e4b95
Compare
|
@ntkathole FYI: this branch also includes a change to the ray / codeflare dependency environment marker. |
ntkathole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
What this PR does / why we need it:
This PR loosens the pyarrow requirement to allow for more recent pyarrow versions
Which issue(s) this PR fixes:
fixes #5609