Skip to content

Conversation

@dlovell
Copy link
Contributor

@dlovell dlovell commented Oct 13, 2025

What this PR does / why we need it:

This PR loosens the pyarrow requirement to allow for more recent pyarrow versions

Which issue(s) this PR fixes:

fixes #5609

@dlovell dlovell marked this pull request as draft October 13, 2025 13:15
@dlovell dlovell changed the title chore(deps): loosen pyarrow chore(deps): Loosen pyarrow Oct 13, 2025
@franciscojavierarceo franciscojavierarceo changed the title chore(deps): Loosen pyarrow chore: Loosen pyarrow Oct 13, 2025
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update setup.py and then run make install-python-dependencies-dev?

Signed-off-by: dlovell <dlovell@gmail.com>
Signed-off-by: dlovell <dlovell@gmail.com>
@dlovell dlovell force-pushed the chore/deps/loosen-pyarrow branch from 4c06ac4 to d56c8f6 Compare October 13, 2025 13:52
@dlovell dlovell marked this pull request as ready for review October 13, 2025 14:11
@dlovell dlovell requested a review from a team as a code owner October 13, 2025 14:11
@franciscojavierarceo
Copy link
Member

hmm looks like macos-14 doesn't like it @ntkathole can you provide some guidance here?

@dlovell
Copy link
Contributor Author

dlovell commented Oct 13, 2025

i'm not sure i created my venv with make install-python-dependencies-dev

i'll start over with a venv created that way

@dlovell
Copy link
Contributor Author

dlovell commented Oct 13, 2025

looks like nvidia-* causes macos to fail and nvidia-* comes from torch / image comes from ci

@ntkathole
Copy link
Member

looks like nvidia-* causes macos to fail and nvidia-* comes from torch / image comes from ci

The requirement file included in PR has nvidia-* dependencies which is only meant for GPU supported systems. You need to make sure make lock-python-dependencies-all do not include those dependencies, I think probably using PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu

@ntkathole
Copy link
Member

Also, fyi - we have APACHE_ARROW_VERSION="17.0.0" added in feast-operator images, which needs to be updated as well.
https://github.com/search?q=repo%3Afeast-dev%2Ffeast%20APACHE_ARROW_VERSION&type=code

@dlovell dlovell force-pushed the chore/deps/loosen-pyarrow branch from 3777db6 to 7a46e80 Compare October 13, 2025 16:54
@dlovell
Copy link
Contributor Author

dlovell commented Oct 13, 2025

@ntkathole FYI: i've modified lock-python-dependencies-all to pass the args necessary to use the pytorch cpu index

its not clear that APACHE_ARROW_VERSION needs to change: its usages seem to be pointing to minimal installs of feast which still refer to 17.0.0

Signed-off-by: dlovell <dlovell@gmail.com>
@dlovell dlovell force-pushed the chore/deps/loosen-pyarrow branch from 7a46e80 to af98a25 Compare October 13, 2025 17:47
@ntkathole ntkathole mentioned this pull request Oct 14, 2025
@ntkathole
Copy link
Member

@ntkathole FYI: i've modified lock-python-dependencies-all to pass the args necessary to use the pytorch cpu index

Looks like it is appending +cpu to the requirement explicitly causing issues. I am not able to push to your branch, so created #5662

its not clear that APACHE_ARROW_VERSION needs to change: its usages seem to be pointing to minimal installs of feast which still refer to 17.0.0

I see, right. No need to update since it's still pin to 17.0.0

Signed-off-by: dlovell <dlovell@gmail.com>
@dlovell dlovell force-pushed the chore/deps/loosen-pyarrow branch from af98a25 to e8e4b95 Compare October 14, 2025 09:58
@dlovell
Copy link
Contributor Author

dlovell commented Oct 14, 2025

@ntkathole FYI: this branch also includes a change to the ray / codeflare dependency environment marker. uv lock fails due to its use of python_full_version if this change is not present.

Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ntkathole ntkathole merged commit 39c243e into feast-dev:master Oct 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The dependency "pyarrow<=17.0.0" does not work with Python 3.13

3 participants