Add index for join table for jobs-featuresets relation#566
Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom Mar 25, 2020
Merged
Add index for join table for jobs-featuresets relation#566feast-ci-bot merged 1 commit intofeast-dev:masterfrom
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
ches
added
the
backport-candidate
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Apr 14, 2020
khorshuheng
pushed a commit
that referenced
this pull request
Apr 14, 2020
Merged
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Apr 24, 2020
ches
pushed a commit
to agoda-com/feast
that referenced
this pull request
Apr 26, 2020
This was referenced Apr 26, 2020
Merged
ches
pushed a commit
that referenced
this pull request
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With a large amount of feature sets and jobs, any operation on the jobs table takes a ridiculous amount of time - due to the fact that the join table is not indexed, resulting in very long JobCoordinator
poll()calls. This PR specifies indexes for the two columns in the join table, which should speed up queries.Tested locally and this should be an automatic upgrade. No migration is required.
Does this PR introduce a user-facing change?: