fix: Update the deprecated functions in Go feature server. #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuchu
requested review from
Copilot and
franciscojavierarceo
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates deprecated Go functions and imports to use their modern equivalents, addressing deprecation warnings in the Go feature server codebase.
- Replace deprecated
io/ioutilfunctions with theirosandioequivalents - Update gRPC client initialization to use the newer
grpc.NewClientAPI - Modernize slice operations using Go 1.21's
slicespackage
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go/internal/feast/server/logging/offlinestoresink.go | Replace ioutil.TempDir with os.MkdirTemp |
| go/internal/feast/server/logging/logger_test.go | Replace ioutil.ReadDir with os.ReadDir |
| go/internal/feast/server/grpc_server_test.go | Update gRPC client creation and replace deprecated functions |
| go/internal/feast/registry/s3.go | Replace ioutil.ReadAll with io.ReadAll |
| go/internal/feast/registry/registry_test.go | Replace ioutil.NopCloser with io.NopCloser |
| go/internal/feast/registry/local.go | Replace ioutil.ReadFile and ioutil.WriteFile with os equivalents |
| go/internal/feast/model/featureview.go | Replace manual loop with slices.Contains |
| go/infra/docker/feature-server/Dockerfile | Update Go version from 1.22.5 to 1.23.12 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
…ast-dev#5626) * Added featureView in the response for search results of features Signed-off-by: Aniket Paluskar <apaluska@redhat.com> * Added tests to check featureView addition in feature search results Signed-off-by: Aniket Paluskar <apaluska@redhat.com> --------- Signed-off-by: Aniket Paluskar <apaluska@redhat.com> Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
shuchu
force-pushed
the
fix/issue-5623
branch
from
7996c84 to
6ea07fb
Compare
ntkathole
reviewed
Sep 24, 2025
| "name": feature.get("name", ""), | ||
| "description": feature.get("description", ""), | ||
| "project": current_project, | ||
| "featureView": feature.get("featureView", ""), |
Member
There was a problem hiding this comment.
This commit is from another PR, probably came while rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are few function calls are deprecated.
Which issue(s) this PR fixes:
Fix #5623
Misc