Skip to content

fix: Push Source inherits the timestamp fields from Data Source #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Aug 4, 2025
Merged

fix: Push Source inherits the timestamp fields from Data Source #5550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,19 @@ def _to_proto_impl(self) -> DataSourceProto:
owner=self.owner,
)

# Only set timestamp fields if we have a batch source and this PushSource doesn't have its own fields
if self.batch_source and not (
self.timestamp_field or self.created_timestamp_column or self.field_mapping
):
data_source_proto.timestamp_field = self.batch_source.timestamp_field
data_source_proto.created_timestamp_column = (
self.batch_source.created_timestamp_column
)
data_source_proto.field_mapping.update(self.batch_source.field_mapping)
data_source_proto.date_partition_column = (
self.batch_source.date_partition_column
)

if self.batch_source:
data_source_proto.batch_source.MergeFrom(self.batch_source.to_proto())

Expand Down
Loading