Change serving and ingestion to use storage API#553
Merged
feast-ci-bot merged 2 commits intofeast-dev:storage-refactorfrom Mar 25, 2020
Merged
Change serving and ingestion to use storage API#553feast-ci-bot merged 2 commits intofeast-dev:storage-refactorfrom
feast-ci-bot merged 2 commits intofeast-dev:storage-refactorfrom
Conversation
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhilingc
changed the title
zhilingc
force-pushed
the
storage-refactor-impl
branch
from
464c046 to
7a9c900
Compare
zhilingc
force-pushed
the
storage-refactor
branch
from
ac711e1 to
27b3c91
Compare
zhilingc
force-pushed
the
storage-refactor-impl
branch
from
7a9c900 to
056c06d
Compare
Collaborator
Author
|
/retest |
woop
reviewed
Mar 24, 2020
serving/src/main/java/feast/serving/configuration/ServingServiceConfig.java
Show resolved
Hide resolved
woop
reviewed
Mar 24, 2020
Member
|
/lgtm |
zhilingc
pushed a commit
that referenced
this pull request
Mar 29, 2020
* Change serving and ingestion to use storage API * Remove extra exclusion clause
zhilingc
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Change serving and ingestion to use storage API * Remove extra exclusion clause
zhilingc
pushed a commit
that referenced
this pull request
Apr 7, 2020
* Change serving and ingestion to use storage API * Remove extra exclusion clause
feast-ci-bot
pushed a commit
that referenced
this pull request
Apr 7, 2020
…567) * Add storage interfaces, basic file structure (#529) * Add storage interfaces, basic file structure * Apply spotless, add comments * Move parseResponse and isEmpty to response object * Make changes to write interface to be more beam-like * Pass feature specs to the retriever * Pass feature specs to online retriever * Add FeatureSetRequest * Add mistakenly removed TestUtil * Add mistakenly removed TestUtil * Add BigQuery storage (#546) * Add Redis storage implementation (#547) * Add Redis storage * Remove staleness check; can be checked at the service level * Remove staleness related tests * Add dependencies to top level pom * Clean up code * Change serving and ingestion to use storage API (#553) * Change serving and ingestion to use storage API * Remove extra exclusion clause * Storage refactor API and docstring tweaks (#569) * API and docstring tweaks * Fix javadoc linting errors * Apply spotless * Fix javadoc formatting * Drop result from HistoricalRetrievalResult constructors * Change pipeline to use DeadletterSink API (#586) * Add better code docs to storage refactor (#601) * Add better code documentation, make GetFeastServingInfo independent of retriever * Make getStagingLocation method of historical retriever * Apply spotless * Clean up dependencies, remove exclusions at serving (#607) * Clean up OnlineServingService code (#605) * Clean up OnlineServingService code to be more readable * Revert Metrics * Rename storage API packages to nouns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Swaps out specific storage implementations in the serving service and ingestion code for the interfaces defined in the serving service.
Additionally addresses Issue #489: the WriteResult is used to write metrics only after successful writes.