fix: Fixed ODFV on-write transformations #5528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
franciscojavierarceo
approved these changes
Jul 21, 2025
Member
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
nice, thank you!
Collaborator
|
This is awesome. @ntkathole, what do you think of refactoring the OnDemandFeatureView to inherit from FeatureView, so that it can use the compute engine? |
Member
Author
That will be great, created #5531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On-Demand Feature Views (ODFVs) with write_to_online_store=True were not persisting transformed values during materialization.
The root causes were:
Added integration tests covering:
Which issue(s) this PR fixes:
Fixes #5430