when rest is enabled for registry, does the default port change?

nope, same default port is used, unless changed explicitly by user.

looking good, but we still need checks added as mentioned in this prior review comment - #5364 (review)

Can you provide an example here, I didn't get how user can set restAPI true in the remote registry ? I think we have only added restAPI flag option for local registry server configs.

A user can reference a registry in another FeatureStore CR and use it as a remote registry -

We already have tests in place (both e2e & unit) around this feature. Given the restAPI breaks this functionality, you'll need to add an additional check in -

and unit test(s) verifying the new check.. e.g. -

A user can reference a registry in another FeatureStore CR and use it as a remote registry -

feast/infra/feast-operator/test/testdata/feast_integration_test_crs/v1alpha1_remote_registry_featurestore.yaml

Lines 11 to 15 in 6c92447

	registry:
	remote:
	feastRef:
	name: simple-feast-setup
	namespace: default

We already have tests in place (both e2e & unit) around this feature. Given the restAPI breaks this functionality, you'll need to add an additional check in -

feast/infra/feast-operator/internal/controller/services/services.go

Lines 749 to 768 in 648c53d

	func (feast *FeastServices) setRemoteRegistryURL() error {
	if feast.isRemoteHostnameRegistry() {
	feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = *feast.Handler.FeatureStore.Status.Applied.Services.Registry.Remote.Hostname
	} else if feast.IsRemoteRefRegistry() {
	remoteFeast, err := feast.getRemoteRegistryFeastHandler()
	if err != nil {
	return err
	}
	// referenced/remote registry must use the local registry server option and be in a 'Ready' state.
	if remoteFeast != nil &&
	remoteFeast.isRegistryServer() &&
	apimeta.IsStatusConditionTrue(remoteFeast.Handler.FeatureStore.Status.Conditions, feastdevv1alpha1.RegistryReadyType) &&
	len(remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry) > 0 {
	feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry
	} else {
	return errors.New("Remote feast registry of referenced FeatureStore '" + remoteFeast.Handler.FeatureStore.Name + "' is not ready")
	}
	}
	return nil
	}

and unit test(s) verifying the new check.. e.g. -

feast/infra/feast-operator/internal/controller/featurestore_controller_test.go

Lines 992 to 1010 in 6c92447

	cond := apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType)
	Expect(cond).NotTo(BeNil())
	Expect(cond.Message).To(Equal("Error: FeatureStore '" + name + "' can't reference itself in `spec.services.registry.remote.feastRef`"))
	resource.Spec.Services.Registry.Remote.FeastRef.Name = "wrong"
	err = k8sClient.Update(ctx, resource)
	Expect(err).NotTo(HaveOccurred())
	_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
	NamespacedName: nsName,
	})
	Expect(err).To(HaveOccurred())
	err = k8sClient.Get(ctx, nsName, resource)
	Expect(err).NotTo(HaveOccurred())
	Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.AuthorizationReadyType)).To(BeNil())
	Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.RegistryReadyType)).To(BeNil())
	Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1alpha1.ReadyType)).To(BeFalse())
	cond = apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType)
	Expect(cond).NotTo(BeNil())
	Expect(cond.Message).To(Equal("Error: Referenced FeatureStore '" + resource.Spec.Services.Registry.Remote.FeastRef.Name + "' was not found"))

This is handled in b991093 Thank you.

Looking good, a few comments.