-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Refactor materialization engine #5354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1729394
move old materialization engines into compute engines
HaoXuAI 467a5b9
move old materialization engines into compute engines
HaoXuAI 277d39f
Merge branch 'master' into refactor-materialization-engine
HaoXuAI b1988d7
fix the test
HaoXuAI 1a9548c
Merge branch 'master' into refactor-materialization-engine
HaoXuAI 3b4912e
fix localcompute
HaoXuAI a667cf8
fix localcompute
HaoXuAI 8a29f65
fix localcompute
HaoXuAI eab3d7f
fix localcompute
HaoXuAI 58a7014
Merge branch 'master' into refactor-materialization-engine
HaoXuAI c5bdcb3
format
HaoXuAI 217a931
fix test
HaoXuAI 96e99b6
fix test
HaoXuAI bd77562
fix test
HaoXuAI 55b1275
merge master
HaoXuAI 65ecb46
fix lint
HaoXuAI 24e3465
fix lint
HaoXuAI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 4 additions & 2 deletions
6
docs/getting-started/components/batch-materialization-engine.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| # Batch Materialization Engine | ||
|
|
||
| Note: The materialization engine is not constructed via unified compute engine interface. | ||
|
|
||
| A batch materialization engine is a component of Feast that's responsible for moving data from the offline store into the online store. | ||
|
|
||
| A materialization engine abstracts over specific technologies or frameworks that are used to materialize data. It allows users to use a pure local serialized approach (which is the default LocalMaterializationEngine), or delegates the materialization to seperate components (e.g. AWS Lambda, as implemented by the the LambdaMaterializaionEngine). | ||
| A materialization engine abstracts over specific technologies or frameworks that are used to materialize data. It allows users to use a pure local serialized approach (which is the default LocalComputeEngine), or delegates the materialization to seperate components (e.g. AWS Lambda, as implemented by the the LambdaComputeEngine). | ||
|
|
||
| If the built-in engines are not sufficient, you can create your own custom materialization engine. Please see [this guide](../../how-to-guides/customizing-feast/creating-a-custom-materialization-engine.md) for more details. | ||
| If the built-in engines are not sufficient, you can create your own custom materialization engine. Please see [this guide](../../how-to-guides/customizing-feast/creating-a-custom-compute-engine.md) for more details. | ||
|
|
||
| Please see [feature\_store.yaml](../../reference/feature-repository/feature-store-yaml.md#overview) for configuring engines. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,7 @@ def __init__( | |
| ttl: Optional[timedelta] = None, | ||
| tags: Optional[Dict[str, str]] = None, | ||
| online: bool = False, | ||
| offline: bool = True, | ||
| offline: bool = False, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be backward compatible for testing |
||
| description: str = "", | ||
| owner: str = "", | ||
| schema: Optional[List[Field]] = None, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other couple of reference to
creating-a-custom-materialization-engine.mdwhich needs to change as wellhttps://github.com/search?q=repo%3Afeast-dev%2Ffeast%20creating-a-custom-materialization-engine.md&type=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, let me update in the next PR