Skip to content

fix: Fix lineage entity filtering #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 3 commits into from
May 5, 2025
Merged

fix: Fix lineage entity filtering #5321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa5bd31
Fix: Entity filtering and permissions in the Lineage tab
devin-ai-integration[bot] May 4, 2025
d3b7a79
Update PR to clarify fix scope
devin-ai-integration[bot] May 4, 2025
6eead66
Remove entity filtering from Feature View Lineage tab
devin-ai-integration[bot] May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 51 additions & 8 deletions ui/src/pages/feature-views/FeatureViewLineageTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
import React, { useContext } from "react";
import React, { useContext, useState } from "react";
import { useParams } from "react-router-dom";
import { EuiEmptyPrompt, EuiLoadingSpinner } from "@elastic/eui";
import {
EuiEmptyPrompt,
EuiLoadingSpinner,
EuiSpacer,
EuiSelect,
EuiFormRow,
EuiFlexGroup,
EuiFlexItem,
} from "@elastic/eui";
import { feast } from "../../protos";
import useLoadRegistry from "../../queries/useLoadRegistry";
import RegistryPathContext from "../../contexts/RegistryPathContext";
import RegistryVisualization from "../../components/RegistryVisualization";
import { FEAST_FCO_TYPES } from "../../parsers/types";
import { filterPermissionsByAction } from "../../utils/permissionUtils";

interface FeatureViewLineageTabProps {
data: feast.core.IFeatureView;
Expand All @@ -20,6 +29,7 @@ const FeatureViewLineageTab = ({ data }: FeatureViewLineageTabProps) => {
data: registryData,
} = useLoadRegistry(registryUrl);
const { featureViewName } = useParams();
const [selectedPermissionAction, setSelectedPermissionAction] = useState("");

const filterNode = {
type: FEAST_FCO_TYPES.featureView,
Expand Down Expand Up @@ -47,12 +57,45 @@ const FeatureViewLineageTab = ({ data }: FeatureViewLineageTabProps) => {
/>
)}
{isSuccess && registryData && (
<RegistryVisualization
registryData={registryData.objects}
relationships={registryData.relationships}
indirectRelationships={registryData.indirectRelationships}
filterNode={filterNode}
/>
<>
<EuiSpacer size="l" />
<EuiFlexGroup style={{ marginBottom: 16 }}>
<EuiFlexItem grow={false} style={{ width: 300 }}>
<EuiFormRow label="Filter by permissions">
<EuiSelect
options={[
{ value: "", text: "All" },
{ value: "CREATE", text: "CREATE" },
{ value: "DESCRIBE", text: "DESCRIBE" },
{ value: "UPDATE", text: "UPDATE" },
{ value: "DELETE", text: "DELETE" },
{ value: "READ_ONLINE", text: "READ_ONLINE" },
{ value: "READ_OFFLINE", text: "READ_OFFLINE" },
{ value: "WRITE_ONLINE", text: "WRITE_ONLINE" },
{ value: "WRITE_OFFLINE", text: "WRITE_OFFLINE" },
]}
value={selectedPermissionAction}
onChange={(e) => setSelectedPermissionAction(e.target.value)}
aria-label="Filter by permissions"
/>
</EuiFormRow>
</EuiFlexItem>
</EuiFlexGroup>
<RegistryVisualization
registryData={registryData.objects}
relationships={registryData.relationships}
indirectRelationships={registryData.indirectRelationships}
permissions={
selectedPermissionAction
? filterPermissionsByAction(
registryData.permissions,
selectedPermissionAction,
)
: registryData.permissions
}
filterNode={filterNode}
/>
</>
)}
</>
);
Expand Down