chore: Refactor transform on write#5300
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
HaoXuAI
approved these changes
Apr 28, 2025
HaoXuAI
left a comment
HaoXuAI
left a comment
Collaborator
There was a problem hiding this comment.
this looks good to me.
But long term I think it's better to refactor with a factory pattern or an abstraction to avoid so many conditions check.
franciscojavierarceo
added a commit
that referenced
this pull request
Apr 28, 2025
jfw-ppi
pushed a commit
to jfw-ppi/feast
that referenced
this pull request
Jun 7, 2025
Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactored code to make it easier toread.
Which issue(s) this PR fixes:
Misc