Skip to content

fix: Remove misleading HTTP prefix from gRPC endpoints in logs and doc #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Apr 18, 2025
+2 −4
Merged

fix: Remove misleading HTTP prefix from gRPC endpoints in logs and doc #5280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/registries/remote.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The `path` parameter is a URL with a port (default is 6570) used by the client t
```yaml
registry:
registry_type: remote
path: http://localhost:6570
path: localhost:6570
```
{% endcode %}

Expand Down
4 changes: 1 addition & 3 deletions sdk/python/feast/registry_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,9 +808,7 @@ def start_server(
server.add_insecure_port(f"[::]:{port}")
server.start()
if wait_for_termination:
logger.info(
f"Grpc server started at {'https' if tls_cert_path and tls_key_path else 'http'}://localhost:{port}"
)
logger.info(f"Grpc server started at localhost:{port}")
server.wait_for_termination()
else:
return server
Expand Down
Loading