Relax OS check when starting e2e test#523
Merged
feast-ci-bot merged 1 commit intofeast-dev:v0.3-branchfrom Mar 9, 2020
Merged
Conversation
davidheryanto
requested review from
pradithya,
thirteen37,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Don't think it works if I'm not in owners files, but, /lgtm |
Member
|
Well I stand corrected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previosly e2e tests check that the system must be running Debian 9 (stretch) before proceeding. But this check may not be necessary as different Debian / Ubuntu versions may still run the e2e tests correctly. Also, the default Debian version used by jdk Docker image may change over time, and this check will prevent newer version of Docker image to pass.
Which issue(s) this PR fixes:
Related to #516
Does this PR introduce a user-facing change?: