Skip to content

fix: Fixed integration tests for qdrant and milvus #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Apr 5, 2025
Merged

fix: Fixed integration tests for qdrant and milvus #5224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,10 +2020,6 @@ def _retrieve_from_online_store(
"""
Search and return document features from the online document store.
"""
vector_field_metadata = _get_feature_view_vector_field_metadata(table)
if vector_field_metadata:
distance_metric = vector_field_metadata.vector_search_metric

documents = provider.retrieve_online_documents(
config=self.config,
table=table,
Expand Down
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/online_stores/qdrant_online_store/qdrant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ def online_write_batch(
encoded_value = base64.b64encode(value.SerializeToString()).decode(
"utf-8"
)
vector_val = json.loads(get_list_val_str(value))
vector_val = get_list_val_str(value)
if vector_val:
vector = {config.online_store.vector_name: json.loads(vector_val)}
else:
vector = {}
points.append(
models.PointStruct(
id=uuid.uuid4().hex,
Expand All @@ -126,7 +130,7 @@ def online_write_batch(
"timestamp": timestamp,
"created_ts": created_ts,
},
vector={config.online_store.vector_name: vector_val},
vector=vector,
)
)

Expand Down
10 changes: 7 additions & 3 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,13 @@ def construct_test_environment(
cache_ttl_seconds=1,
)

if isinstance(
test_repo_config.online_store, dict
) and test_repo_config.online_store.get("type") in ["milvus", "pgvector", "qdrant"]:
online_store = (
test_repo_config.online_store.get("type")
if isinstance(test_repo_config.online_store, dict)
else test_repo_config.online_store
)

if online_store in ["milvus", "pgvector", "qdrant"]:
entity_key_serialization_version = 3

environment_params = {
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ def test_retrieve_online_documents(environment, fake_document_data):
fs.write_to_online_store("item_embeddings", df)

documents = fs.retrieve_online_documents(
features=["item_embeddings:embedding_float"],
features=["item_embeddings:embedding_float", "item_embeddings:item_id"],
query=[1.0, 2.0],
top_k=2,
distance_metric="L2",
Expand Down
Loading