Skip to content

chore: Support "offline" source builds of the feature-server image #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
franciscojavierarceo merged 2 commits into from
Apr 3, 2025
Merged

chore: Support "offline" source builds of the feature-server image #5193

franciscojavierarceo merged 2 commits into from
Apr 3, 2025

Conversation

@tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Mar 27, 2025 •
edited
Loading

What this PR does / why we need it:

We should be able to build the feature-server image entirely from source, dependencies and all. This PR almost entirely accomplishes that. With this PR we also add a new limited pip dependency group, among others, which we'll use going forward in our feature-server image builds and for operator e2e tests.

In order to accomplish the offline builds from source w/ pip, we use a tool called cachi2, which pre-fetches the sdists/archives and enables us to mount the fetched sources into an offline build container.

From a linux-x64 machine, the following command will complete an offline build from source -

$ source ./infra/scripts/offline-build.sh

The following pip modules are not yet built from source, many due to maturin related source build issues -

# we'll need to pip install anything that tries to build/use maturin from source
############
# feast deps
pydantic_core==2.27.2
watchfiles==1.0.4
rpds-py==0.23.1
# snowflake dep
cryptography==44.0.2
# aws dep
aiohttp==3.11.14
# psycopg dep
psycopg-binary==3.2.5
# milvus dep
milvus-lite==2.4.12
############

Misc

Completed build from source available here - quay.io/tchughesiv/feature-server:0.47.0-sdist

@tchughesiv tchughesiv changed the title chore: Support building feature-server images from source chore: Support for building feature-server images from source Mar 27, 2025
@tchughesiv tchughesiv changed the title chore: Support for building feature-server images from source chore: Support for building the feature-server image from source Mar 27, 2025
@tchughesiv tchughesiv force-pushed the noBinary branch 3 times, most recently from 504eed8 to 005db0f Compare March 27, 2025 19:49
@tchughesiv tchughesiv marked this pull request as ready for review March 27, 2025 20:24
@tchughesiv tchughesiv requested a review from a team as a code owner March 27, 2025 20:24
@tchughesiv tchughesiv changed the title chore: Support for building the feature-server image from source chore: Support offline source builds of the feature-server image Mar 27, 2025
@tchughesiv tchughesiv changed the title chore: Support offline source builds of the feature-server image chore: Support "offline" source builds of the feature-server image Mar 27, 2025
@tchughesiv tchughesiv marked this pull request as draft March 27, 2025 20:31
@tchughesiv tchughesiv force-pushed the noBinary branch 3 times, most recently from 4355d95 to f4ccc80 Compare March 27, 2025 22:41
@tchughesiv tchughesiv marked this pull request as ready for review March 28, 2025 01:41
@tchughesiv tchughesiv marked this pull request as draft March 28, 2025 16:14
@tchughesiv tchughesiv marked this pull request as ready for review March 28, 2025 20:16
jyejare
jyejare reviewed Apr 1, 2025
View reviewed changes
@tchughesiv tchughesiv force-pushed the noBinary branch 5 times, most recently from a2a8f41 to d362522 Compare April 1, 2025 15:56
@tchughesiv
support offline source builds for feature-server image
fdb664e 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
ntkathole
ntkathole reviewed Apr 2, 2025
View reviewed changes
@tchughesiv
offline build review changes
3e33393 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
@tchughesiv
Copy link
Contributor Author

tchughesiv commented Apr 2, 2025

@ntkathole i've made the requested changes and am now running another build to ensure nothing breaks. thanks

@ntkathole
Copy link
Member

ntkathole commented Apr 2, 2025

@ntkathole i've made the requested changes and am now running another build to ensure nothing breaks. thanks

a small comment, otherwise, Looks good to me !

@tchughesiv
Copy link
Contributor Author

tchughesiv commented Apr 2, 2025

@ntkathole the build was successful with your requested changes

ntkathole
ntkathole approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

franciscojavierarceo
franciscojavierarceo approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/linter.yml
os: [ ubuntu-latest ]
env:
PYTHON: 3.11
OS: ${{ matrix.os }}
Copy link
Member

@franciscojavierarceo franciscojavierarceo Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@tchughesiv tchughesiv Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i've enabled this job to run against multiple python versions

@franciscojavierarceo franciscojavierarceo enabled auto-merge (squash) April 3, 2025 12:37
@tchughesiv tchughesiv removed the request for review from redhatHameed April 3, 2025 12:40
@tchughesiv tchughesiv disabled auto-merge April 3, 2025 12:42
@tchughesiv tchughesiv enabled auto-merge (squash) April 3, 2025 12:43
@franciscojavierarceo franciscojavierarceo merged commit cc1fcad into feast-dev:master Apr 3, 2025
26 of 31 checks passed
This was referenced Apr 4, 2025
Merged
Merged
@tchughesiv tchughesiv mentioned this pull request Apr 15, 2025
Merged
This was referenced May 1, 2025
Merged
Merged
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request Jun 7, 2025
@tchughesiv @jfw-ppi
chore: Support "offline" source builds of the feature-server image (f…
4180b18 
…east-dev#5193)

* support offline source builds for feature-server image

Signed-off-by: Tommy Hughes <tohughes@redhat.com>

* offline build review changes

Signed-off-by: Tommy Hughes <tohughes@redhat.com>

---------

Signed-off-by: Tommy Hughes <tohughes@redhat.com>
Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

@ntkathole ntkathole ntkathole approved these changes

+1 more reviewer

@jyejare jyejare jyejare left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tchughesiv @ntkathole @franciscojavierarceo @jyejare