chore: Add format-ui Makefile target#5187
Merged
Merged
Conversation
This was requested in feast-dev#5149. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
franciscojavierarceo
approved these changes
Mar 25, 2025
redhatHameed
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a Makefile target for formatting the UI code.
Which issue(s) this PR fixes:
This was requested in #5149 (if I understood the request correctly).
Misc
The
uidirectory requires theNPM_TOKENenvironment variable to exist to run any package manager command via .npmrc. I just always define it to an empty value like in these changes, don't know if there is a more convenient way, or if we can assume that the developer already has it defined in their environment.